Giter Club home page Giter Club logo

Comments (4)

khasanovbi avatar khasanovbi commented on June 11, 2024

#711

from go-grpc-middleware.

johanbrandhorst avatar johanbrandhorst commented on June 11, 2024

I left a comment on your PR before seeing this issue, sorry. I don't think this is necessary, you can just fork the interceptor if you want to change the behavior.

from go-grpc-middleware.

khasanovbi avatar khasanovbi commented on June 11, 2024

Hi @johanbrandhorst
I could explain this is necessary for me:

  1. This changes allow to customize ugly protovalidate error message to more convenient.
    Sample of usage in my project:
	var targetErr *protovalidate.ValidationError
	if !errors.As(err, &targetErr) {
		return err
	}

	builder := strings.Builder{}
	for i, violation := range targetErr.Violations {
		builder.WriteString(violation.FieldPath)
		builder.WriteString(": ")
		builder.WriteString(violation.Message)

		if i == len(targetErr.Violations)-1 {
			continue
		}

		builder.WriteString("\n")
	}
  1. This changes could add ability to use status.WithDetails and pass field violations in details proto, i.e. use such proto https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto#L170

from go-grpc-middleware.

johanbrandhorst avatar johanbrandhorst commented on June 11, 2024

I appreciate that it might be useful to you, but it's very easy to just copy the logic from the interceptors instead of adding more complexity. Please feel free to copy it (as long as you include the license, of course) and make the changes you want.

from go-grpc-middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.