Comments (4)
from go-grpc-middleware.
I left a comment on your PR before seeing this issue, sorry. I don't think this is necessary, you can just fork the interceptor if you want to change the behavior.
from go-grpc-middleware.
Hi @johanbrandhorst
I could explain this is necessary for me:
- This changes allow to customize ugly protovalidate error message to more convenient.
Sample of usage in my project:
var targetErr *protovalidate.ValidationError
if !errors.As(err, &targetErr) {
return err
}
builder := strings.Builder{}
for i, violation := range targetErr.Violations {
builder.WriteString(violation.FieldPath)
builder.WriteString(": ")
builder.WriteString(violation.Message)
if i == len(targetErr.Violations)-1 {
continue
}
builder.WriteString("\n")
}
- This changes could add ability to use
status.WithDetails
and pass field violations in details proto, i.e. use such proto https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto#L170
from go-grpc-middleware.
I appreciate that it might be useful to you, but it's very easy to just copy the logic from the interceptors instead of adding more complexity. Please feel free to copy it (as long as you include the license, of course) and make the changes you want.
from go-grpc-middleware.
Related Issues (20)
- Support loggging grpc status details HOT 1
- Add source and target endpoint as label for all client/server grpc metrics HOT 2
- Support ignore logging for v2(already attached PR) HOT 3
- Prometheus metrics label value inconsistency between Go and Java HOT 3
- [logging] disable option does not work with request/response fields HOT 6
- go-grpc-middleware/providers/openmetrics/v2 v2.0.0-rc.3 dependency of go-grpc-middleware/v2 v2.0.1 broken HOT 8
- Q: Logger migration HOT 2
- Support extensibility of retry condition
- [feat]: logging should loging grpc request msg HOT 1
- Example will log only first field HOT 3
- Add Capability to Override Base Timeout for Specific API HOT 1
- Use retry hooks for adding retry metrics
- logging.InjectFields does not work. HOT 1
- Use of golang.org/x/net/trace prevents dead code elimination HOT 1
- providers/prometheus v1.0.0 dependent on go-grpc-middleware v2.0.0-rc.3 HOT 6
- Feature: Auth Interceptor: Add support for partial per service AuthFunc override HOT 2
- WithDecider gone but referenced on documentation HOT 1
- Go version support policy? HOT 1
- Support for WithNamespace()
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-grpc-middleware.