Hi,

In versions previous to v1.6.0, a belongs_to or has_one association may have dependent: :nullify and everything works fine. After v1.6.0 this no longer works, because it was changed to an update_all which doesn't work on singular dependencies because they don't have a scope.

The error looks like this:

NoMethodError: undefined method `update_all' for #<Foo:0x000055670f32a7c8>

See a2302b4

Thanks!

Recently I've been adding some functionality to our app to hard-delete certain records in order to comply with European regulations. As a result of this, I've been adding dependent: :nullify to a lot of our associations.

The comment I want to make is that I think soft_deletion should basically disregard the "nullify" option. It only really has any relevance in the case of hard deletion, where we nonetheless are willing to keep certain orphaned records around. We do still use soft_deletion in most cases, and I don't want to set these records as :destroy just to avoid soft_delete nullifying them.

I figured this is worth discussing so I decided to make an issue about it. Thanks for the gem.

in the README, you say:

# soft delete them including all dependencies that are marked as :destroy, :delete_all, :nullify

But it seems we actually only soft-delete associations that also support soft_delete:
https://github.com/grosser/soft_deletion/blob/master/lib/soft_deletion/core.rb#L23

That's a fine strategy but we should say so if that's the intention...

Hey there,

I tried updating an existing application to Rails 7, and the version for this gem dropped from 1.6.0 to 0.5.6 - I guess because that was the latest version that didn't have any active record dependencies declared in the gemspec.

Is this gem still maintained and are there any plans to support Rails/ActiveRecord 7?

I think I found a real problem this time. Just to be sure, here's a spec as a git patch.

patch.txt

Hi,

First of all, thank you for writing this library 👍

Would you consider keeping a simple change log between releases? I tend to check change logs before updating libraries my apps depends on, but I don't see one for this library. It's much easier to check a change log to see what's backwards incompatibile and what's fixed than to dive into commit logs.

Thanks!

When you add a uniqueness validation with a particular scope to a soft-deletable model Dog, e.g.:

validates :dog_id , uniqueness: { scope: :owner_id }

The scope you pass overrides the soft deletion default scope, so soft-deleted Dogs will make this validation fail.
As a workaround, I had to do something like this:

validates :dog_id, uniqueness: { scope: :owner_id , conditions: -> { where(deleted_at: nil) } }

It works fine, but I reckon ActiveRecord should just treat soft-deleted records as if they don't exist, regardless of what scope you pass, unless you explicitly call with_deleted.

Instead of (or in addition to) Object.with_deleted { current_user.objects.find(...) }

We should have:
current_user.objects.with_deleted.find(...)

I was looking in https://github.com/sricc/soft_deletion/blob/master/lib/soft_deletion/core.rb

and it looks like you could just add this:

scope :with_deleted, -> {
    unscoped {}
}

Note: I'm using Ruby 2.0, and Rails 4

Just cases like User.with_deleted { User.first } no longer work. It complains that core.rb line 23 is expecting an ActiveRecord::Relation. We've had to roll back to 0.7.0 for now.