Giter Club home page Giter Club logo

Comments (11)

Griffintaur avatar Griffintaur commented on September 24, 2024

cool. Go ahead

from news-at-command-line.

ctrlsam avatar ctrlsam commented on September 24, 2024

@Griffintaur I have submitted a PR, do you think you can take a look at it, thanks

from news-at-command-line.

ctrlsam avatar ctrlsam commented on September 24, 2024

@Griffintaur depending on what you want, you might want to think about having the Python 2.7 version in a separate branch for those that don't use Python 3.

from news-at-command-line.

TomFaulkner avatar TomFaulkner commented on September 24, 2024

Is this going to get merged? I noticed there are several unmerged PRs and master hasn't been updated in months.

from news-at-command-line.

ctrlsam avatar ctrlsam commented on September 24, 2024

I know right, this is a little frustrating. If it is not merged after a week I'll make a separate repo.

from news-at-command-line.

TomFaulkner avatar TomFaulkner commented on September 24, 2024

from news-at-command-line.

ctrlsam avatar ctrlsam commented on September 24, 2024

@TomFaulkner I have not changed file names/paths. If it helps, you can fork my copy: https://github.com/SillySam/News-At-Command-Line

I will be happy to contribute to your copy as this guy doesn't seem to active.

PS: I am just about to make another change on my fork that removes the owner's file headers and email, etc.

from news-at-command-line.

ctrlsam avatar ctrlsam commented on September 24, 2024

@TomFaulkner I also want to note, when you make your own copy, please make your API key as I don't think the owner would like the key going viral :D

from news-at-command-line.

TomFaulkner avatar TomFaulkner commented on September 24, 2024

Yeah, that is what I had in mind. Since moving to Python 3, without maintaining 2.7 compatibility is a breaking change, I think it would be a good time to make other breaking changes for PEP8 and a more pythonic ways of doing things.

from news-at-command-line.

TomFaulkner avatar TomFaulkner commented on September 24, 2024

Posted this as a PR on @sillysam's fork. But, thought I would mention it here. I have a more Pythonic fork from @sillysam's fork. I cleaned up quite a bit, more still needs done, but it's posted at least. I plan to do more as I get time.

https://github.com/TomFaulkner/News-At-Command-Line

from news-at-command-line.

TomFaulkner avatar TomFaulkner commented on September 24, 2024

Since this was merged, I moved discussion to #30 so this issue can be closed.

from news-at-command-line.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.