greifent / afc-gui Goto Github PK

Describe the bug
With a fresh install of Linux Mint, I am trying to get this running.

To Reproduce

1. Install using user@machine:~/Downloads$ sudo gitpack install https://github.com/Greifent/afc-gui.git
2. Input password, and get this output

[sudo] password for user:         
>>> running install for https://github.com/Greifent/afc-gui.git
local repository fresh
reading status database
using automatic candidate version
<<< already installed

3. Run using

user@machine:~/Downloads$ afc-gui

4. See error

Traceback (most recent call last):
  File "/usr/bin/afc-gui", line 8, in <module>
    gi.require_version('Gtk', '4.0')
  File "/usr/lib/python3/dist-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available for version %s' %
ValueError: Namespace Gtk not available for version 4.0
Error in sys.excepthook:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apport_python_hook.py", line 153, in apport_excepthook
    with os.fdopen(os.open(pr_filename,
FileNotFoundError: [Errno 2] No such file or directory: '/var/crash/_usr_bin_afc-gui.1000.crash'

Original exception was:
Traceback (most recent call last):
  File "/usr/bin/afc-gui", line 8, in <module>
    gi.require_version('Gtk', '4.0')
  File "/usr/lib/python3/dist-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available for version %s' %
ValueError: Namespace Gtk not available for version 4.0
user@machine:~/Downloads$ 

Expected behavior
The GIU should open up

Once temperatures are changed in afc-gui using a button, the active temperatures on the top of the window are not refreshed with new temperature values. It would be great if they refresh in those cases.

It would be great to add the afc GitHub topic to this repository to make it consistent with other asus-fan-control related projects.

It would be great to add a demonstration image of this program running to the README.md so that people know what to expect. This image can also motivate others to download afc-gui. 🎉

Feel free to add the image once you do not expect changing the program's design for a while. It does not have to be done right now so that the image is not changed every other commit or so, which is not so good for Git repositories. 😄

Similarly to #1, it would be great to add the gitpack GitHub topic to this repository to make it consistent with other gitpack related projects.

Thank you for developing and maintaining this project! ❤️ 🚀 Hope you are doing fine with the university stuff and so! 😄

The testing.py script does not have the execution permission and hence it is not runnable out of the box. chmod +x will gladly fix it. 🔨

Describe the bug
afc-gui wont start and says

gi.repository.GLib.Error: g-file-error-quark: Failed to open file “/usr/share/afc-gui/MAINGUI.glade”: No such file or directory (4)

To Reproduce
Steps to reproduce the behavior:

1. Go to 'afc-gui'
2. See error

Expected behavior
Traceback (most recent call last):
File "/usr/bin/afc-gui", line 188, in
builder.add_from_file(pathglade)
gi.repository.GLib.Error: g-file-error-quark: Failed to open file “/usr/share/afc-gui/MAINGUI.glade”: No such file or directory (4)

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
...................................................................
You should never use relative paths to files, so you need to figure out an absolute path at runtime usually by defining an install prefix at build time. Also ideally you use GResources to simplify the process and improve performance.

An example would be something like this:

https://github.com/pithos/pithos/blob/master/bin/meson.build
https://github.com/pithos/pithos/blob/master/bin/pithos.in#L40-L41
See also: https://developer.gnome.org/gio/stable/GResource.html

You can get more help if you stop by #newcomers on ircs://irc.gimp.net or https://riot.im/app/#/room/#gimpnet#newcomers:matrix.org

I tried to google the answer. But it was too geeky for me.
............................................................
Linux Asus-s451lb 5.13.19-2-MANJARO #1 SMP PREEMPT Sun Sep 19 21:31:53 UTC 2021 x86_64 GNU/Linux

I tried on my ASUS ROG STRIX GL704GW with Ubuntu 20.04 LTS

Linux ajlennon-Strix-GL704GW-GL704GW 5.11.0-37-generic #41~20.04.2-Ubuntu SMP Fri Sep 24 09:06:38 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

It doesn't seem to be supported. You might be interested in the errrors from dmesg

[  494.452539] ACPI Warning: \_SB.PCI0.LPCB.EC0.WRAM: Insufficient arguments - Caller passed 2, method requires 3 (20201113/nsarguments-232)
[  494.454435] ACPI Warning: \_SB.PCI0.LPCB.EC0.WRAM: Insufficient arguments - Caller passed 2, method requires 3 (20201113/nsarguments-232)
[  494.456331] ACPI Warning: \_SB.PCI0.LPCB.EC0.WRAM: Insufficient arguments - Caller passed 2, method requires 3 (20201113/nsarguments-232)
[  494.458299] ACPI Warning: \_SB.PCI0.LPCB.EC0.WRAM: Insufficient arguments - Caller passed 2, method requires 3 (20201113/nsarguments-232)
[  494.460292] ACPI Warning: \_SB.PCI0.LPCB.EC0.WRAM: Insufficient arguments - Caller passed 2, method requires 3 (20201113/nsarguments-232)
[  518.410153] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.413367] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.416543] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.419759] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.422937] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.426287] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.429587] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)
[  518.432801] ACPI Warning: \_SB.PCI0.LPCB.EC0.RRAM: Insufficient arguments - Caller passed 1, method requires 2 (20201113/nsarguments-232)

Cheers.

Describe the bug
afc-gui can't display cpu temp despite having all dependencies. ux430ua

Screenshots

Hi, @dominiksalvet I'm currently working on a preset choice (ex 100%, 75% etc); I've created a xlsx file with the presets and the temperature to set. If you could take a look and let me know about those temperatures.
Here is the file: Presets.xlsx
Thank you!
Here there is also another file with some info for the presets: Info_on_presets.docx

I am really happy that you have adopted GitPack in this project! 😃

But your local installation target directory for afc-gui.py does not seem to be correct. You probably would not want to have all binaries of locally (per user) installed programs in your home directory which is also visible from a file manager. Moreover, home directory is not in the PATH environment variable, so you cannot run your program just by typing its file name. So typing afc-gui.py in a terminal won't work on most, if not all, Linux setups. You would need to use /home/<user>/afc-gui.py command to actually run it.

So I am suggesting to change it from "$HOME" to "$HOME/.local/bin", which is in the PATH at least on Ubuntu-based systems (after reboot if ~/.local/bin is freshly created). Feel free to get inspired from afc-scout, which may be similar in many GitPack-related cases.

Nevertheless, I think that sooner or later you may want to create an application launcher in ~/.local/share/applications as well. It can be directly run from GNOME Shell.

The temperature presets is a good idea for a GUI as such but its current implementation is not so good (note that it affect yours GitPack map file). I would be for something similar to asus-fan-control's models database (<preset-name><separator><temperatures> per line), which could be placed somewhere in ~/.local/share. Once user wants to choose a new preset to apply, it would read all presets from one file and it could present all presets in a better way than wanting the user to find an .afc file manually. Current presets are cumbersome in GitPack (and any package manager) matter. Just my opinion... 😄

Since your repository does not contain a license file, you retain all rights and do not share any of them with others. Once you attach a license to this repository, you will say users exactly what they can and cannot do with your software/source code.

I suggest using an open-source license - the best would be the MIT License as the rest of asus-fan-control software is licensed under the same license. Keep in mind that even in case of using such a permissive license like MIT, you still will be the copyright owner. ©️

What do you think? 📜

Is your feature request related to a problem? Please describe.
In default, GitPack picks the latest tag (release) to install for end users. If there are no tags (which is this repository's case), GitPack uses the latest commit of a default branch (master branch), which may not be always stable.

Let's say there are two tags – 1.2.2 and 1.2.3 (most recent). When we use gitpack install github.com/Greifent/afc-gui, it will use 1.2.3 tag. We can explicitly say which version to use as follows gitpack install github.com/Greifent/afc-gui=1.2.2. Or even if there are tags, we can use the latest commit – gitpack install github.com/Greifent/afc-gui=master. GitPack is clever enough to update/downgrade between versions.

Describe the solution you'd like
Once the current state of the Git repository is considered a new version, add an associated Git tag. E.g., use git tag 1.2.3 and then you need to push it explicitly – git push origin 1.2.3. Once it is pushed, it will appear on GitHub and you can create a release (which is a GitHub thing) from it. That should do it.

Traceback (most recent call last):
  File "./afc-gui", line 5, in <module>
    import gi
ModuleNotFoundError: No module named 'gi'

`sudo apt-get install -y python-gobject

`I did this , still didnt work

It would be great to handle asus-fan-control error messages and create an error dialog for them once they occur as the output in terminal may be overlooked (and in the future, afc-gui may run as an application without any terminal at all). Note that all error messages are written to a standard error stream so it may be possible to catch this stream in the afc-gui somehow and process it there.

E.g., trying to set custom temps with invalid temperatures in the text entry.

Hello @Greifent! 👋

For over a year I have been working on a stable release of GitPack, version 1.0.0. After all the work and polishing details, I think that the new GitPack is very close and I expect no further code-related changes. Since you are currently the only developer (except me), who uses GitPack in their projects, I wanted to let you know this fact and created this issue to track the GitPack 1.0.0 transition in afc-gui. Once GitPack 1.0.0 is out, a new AFC version (with GitPack 1.0.0 format) will be released as well. Please note that GitPack 1.0.0 is incompatible with lower versions.

So what changed from the developer's point of view? One thing basically. The .gitpack directory is now .install directory with a simplified structure. Also, GitPack 1.0.0 no longer uses map file and all (un)installation is done within executable files (it may be Shell scripts, Python, pretty much anything). The complete list of changes is in the changelog. Grap some coffee to read through it! ☕ 😃

The GitPack master branch contains the most recent code changes, while the update-md-files branch contains MD files prepared for GitPack 1.0.0 (use this branch for getting information about new GitPack). If you read the MD files in the update-md-files branch, you will be able to switch your repository to GitPack 1.0.0 yourself. Once 1.0.0 is released, I will also have prepared a transition guide for users of GitPack packages (end users of our programs). The packages must be uninstalled using 0.7.0 and installed back using 1.0.0. Please, watch GitPack for releases so that you won't miss the release. 🚀

So what I propose for you to do now? Switch afc-gui to the new GitPack 1.0.0 format and keep it in the master branch (do not worry, it should be easy for afc-gui). Do not release any versions before GitPack 1.0.0 is out so that GitPack 0.7.0 still uses a compatible afc-gui version. When 1.0.0 is out, the 0.7.0 will become deprecated. You can get inspired by my GitPack repositories, which are already prepared for GitPack 1.0.0 the same way -- waiting for the release in the master branch.

Should you have any issues/questions, let me know!

Describe the bug
ASUS GL502VS is not reporting the CPU Temp and the model info. If I launch the afc-gui with the sudo command the gui reports the model info but the CPU Temp is not still reporting.

To Reproduce
Steps to reproduce the behavior:

1. Launch the afc-gui
2. See error

Expected behavior
Expected to report the CPU Temp and the model info.

Screenshots

Additional context
-I've already installed the CPU-temperature-monitor.
-Afc works fairly well even though CPU temp is not working on gui.