Giter Club home page Giter Club logo

Comments (16)

gregberge avatar gregberge commented on May 25, 2024 3

Yeah you have to change entry I think, just that.

from error-overlay-webpack-plugin.

dehghani-mehdi avatar dehghani-mehdi commented on May 25, 2024 3

@neoziro if you can't fix the issue (because of time limit or whatever), at least don't close the issue with simple answer that don't even fix the issue (I guess you are not sure neither as you mentioned I think in your answer). obviously I can not change my webpack config just because your plugin likes it that way.

Please don't contribute to open source, but if you do be professional at it. I'll remove your plugin, simply because I can not write my webpack config based on your buggy code.

I see you added help wanted tag to almost all issues. if you can not support (clearly you can't), at least add a note in README, so users can make better decision about using your code.

from error-overlay-webpack-plugin.

dehghani-mehdi avatar dehghani-mehdi commented on May 25, 2024 2

To anyone who like to have error overlay without error-overlay-webpack-plugin, the solution is very simple, just run npm i react-dev-utils -D and change the entry option of your webpack.config.js to: [require.resolve('react-dev-utils/webpackHotDevClient'), './index.jsx'], I'm using this method for months.

Remember, you should use react-dev-utils only in development mode.

from error-overlay-webpack-plugin.

dehghani-mehdi avatar dehghani-mehdi commented on May 25, 2024 1

@neoziro I cloned error-overlay-webpack-plugin, without any change the provided example works fine (of course I changed const ErrorOverlayPlugin = require('../lib') to const ErrorOverlayPlugin = require('../src')). also I updated wabpack packages and again everything works fine. I think I have to test the code with one of my projects. If I do (and could fix the problem), I'll post the result here or submit PR for it.

from error-overlay-webpack-plugin.

vitormv avatar vitormv commented on May 25, 2024

Having same error here

from error-overlay-webpack-plugin.

undermuz avatar undermuz commented on May 25, 2024

Have same error

from error-overlay-webpack-plugin.

gregberge avatar gregberge commented on May 25, 2024

Hello, OK it is a bug. Could someone submit a PR to fix it?

from error-overlay-webpack-plugin.

YaoKaiLun avatar YaoKaiLun commented on May 25, 2024

It's ok in v0.1.6 but not in v0.1.7.

from error-overlay-webpack-plugin.

YaoKaiLun avatar YaoKaiLun commented on May 25, 2024

Changing "entry: './static/src/index.js'" to "entry: ['./static/src/index.js']"

from error-overlay-webpack-plugin.

gregberge avatar gregberge commented on May 25, 2024

Hello @dehghani-mehdi, if you are not happy feel free to fix this plugin with a PR or simply don't use it.

from error-overlay-webpack-plugin.

dehghani-mehdi avatar dehghani-mehdi commented on May 25, 2024

@neoziro, Hi, don't worry, I don't use it anymore, I mentioned that in my prev comment.

from error-overlay-webpack-plugin.

gregberge avatar gregberge commented on May 25, 2024

I don’t worry πŸ€—

from error-overlay-webpack-plugin.

dehghani-mehdi avatar dehghani-mehdi commented on May 25, 2024

Good for you ;)

from error-overlay-webpack-plugin.

gregberge avatar gregberge commented on May 25, 2024

@dehghani-mehdi feel free to submit a PR with an upgraded version of react-dev-utils. I see that there is a new version but I don't have enough time to test if everything work on react-dev-utils v9.

from error-overlay-webpack-plugin.

dehghani-mehdi avatar dehghani-mehdi commented on May 25, 2024

Looks like it already fixed by #43

from error-overlay-webpack-plugin.

gregberge avatar gregberge commented on May 25, 2024

Good!

from error-overlay-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.