Giter Club home page Giter Club logo

Comments (6)

MichaelKheel avatar MichaelKheel commented on May 23, 2024 5

Guys, please make a merge.

from error-overlay-webpack-plugin.

milosivanovic avatar milosivanovic commented on May 23, 2024 4

Hello! I posted a fix (#88) for this issue a week ago. @gregberge and @thedavidprice are you able to take a look?

from error-overlay-webpack-plugin.

WizardCM avatar WizardCM commented on May 23, 2024

I can confirm I ran into the same issue today. Reproducible if the Webpack config has a simple

devServer: {}

And goes away if that option is not specified.

from error-overlay-webpack-plugin.

thedavidprice avatar thedavidprice commented on May 23, 2024

Confirming this bug as well when trying to upgrade on RedwoodJS, which is using Webpack v5 and Webpack-dev-server v4 (compatible with v5).

There were many breaking changes in devServer v4:

Looks like this change here:

The before option was renamed to onBeforeSetupMiddleware and changed arguments.

...is potentially causing an issue here:

options.devServer.before = (app, server) => {

Additionally, it seems the following "sock*" changes will also cause problems:

public, sockHost, sockPath, and sockPort options were removed in favor client.webSocketURL option:

...over here:

sockOptions.sockHost = compiler.options.devServer.sockHost
sockOptions.sockPath = compiler.options.devServer.sockPath
sockOptions.sockPort = compiler.options.devServer.sockPort

from error-overlay-webpack-plugin.

gregberge avatar gregberge commented on May 23, 2024

Hi, could someone work on a PR to fix it?

from error-overlay-webpack-plugin.

thedavidprice avatar thedavidprice commented on May 23, 2024

If someone can lead on the PR, I am available to help with questions and diagnosing issues. Just loop me in if/as needed.

from error-overlay-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.