greengiraffe / wingspan-helper Goto Github PK

I only have a few tiny suggestions for 'improvement', take them as you wish:

• for the new Nectar row, would be nice to somehow indicate it only
  applies to the Oceania expansion. I don't think the row should show/hide,
  just if someone only has the base game, they might wonder "What's Nectar?
  What am I missing?"
• in my fork, I reduced the left/right margins and padding as much as
  possible, and squeezed the left column slightly to give maximum space for
  the names. With 5 players, on a phone screen, it's a little cramped
• on a phone-width screen (I use Chome's DevTools device toolbar, my
  phone display is closest to 'Pixel 2' size), on the bottom line, there's an
  unfortunate line-break in the middle of "Nils Cordes"

[image: image.png]

On Tue, Dec 22, 2020 at 11:45 AM Valentin von Guttenberg <
[email protected]> wrote:

Fixed. Used a wrong compare function for sorting the scores.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARGAKDQ7DFOKFZLH5NYH7PLSWDEI7ANCNFSM4URLZ42Q
.

Originally posted by @verdantPermission in #10 (comment)

See PR #10 (comment)

Make clear who has won by highlighting the winning player column or total score somehow. Only highlight the winner, when the total is revealed.

Ideas for highlighting the winner:

• different background for the winner column
• bold or cursive total score
• some fancy animation
• a star (or bird icon) in the winner column

Instead of the numbering (1-5), users should be able to set the player names.

Possible solutions:

• Make top scoresheet row titles editable inputs
• Add extra button that opens a popup that allows setting the player names, which in turn updates the top scoresheet row

Add a German translation for the scoresheet and a toggle to switch between languages.

Add the Automata helper for solo playing.

Optional: Add support for the Europe/Oceania extension

The automata branch includes the routing and basic styles for a tabbed interface that lets you choose between the scoresheet and the automata.

Using Chrome, I cleared my cache, deleted my stored state.
Started with 4,5,6,7,8 in the birds row, and showed Total, and All the
totals were underlined.
Added some bonus scores, and getting odd behaviour.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARGAKDUOUNZW2PFNCBXYUSTSV7BSPANCNFSM4URLZ42Q
.

Originally posted by @verdantPermission in #10 (comment)