Giter Club home page Giter Club logo

Comments (5)

terjeio avatar terjeio commented on May 26, 2024

I'll look into this later - I have a busy weeh ahead.

from stm32f1xx.

LaurentLM avatar LaurentLM commented on May 26, 2024

Thanks Terje - no rush.

Out of curiosity, I tried a few other things on my side:
Reverting to a commit from February 2023 and the issue still happens.
When a program is running, e-stop triggers Alarm 3 and stops the program.
When homing, e-stop triggers Alarm 6, as expected.

Let me know if there is anything else I can do to help troubleshooting.

from stm32f1xx.

LaurentLM avatar LaurentLM commented on May 26, 2024

E-stop now works as expected and triggers alarm. Thanks for looking into this!

I did look at the fix and, as I understand it, the if statement below is always true:

STM32F1xx/Src/driver.c

Lines 2094 to 2095 in 0903727

if(input->mode.irq_mode == IRQ_Mode_Change ||
DIGITAL_IN(input->port, input->pin) == (input->mode.irq_mode == IRQ_Mode_Falling ? 0 : 1) || true) {

Not sure this is related, but I also get an error when probing (same as issue 499. The probe now triggers Alarm 4 (and stops moving) just after the first contact.
Looking at the code, I cannot figure out why the changes impacted the probe.

from stm32f1xx.

terjeio avatar terjeio commented on May 26, 2024

I did look at the fix and, as I understand it, the if statement below is always true:

My bad, I added the always true when debugging - will fix in the next commit.

The probe now triggers Alarm 4 (and stops moving) just after the first contact.

The retract (latch) distance is too short?

from stm32f1xx.

LaurentLM avatar LaurentLM commented on May 26, 2024

Thanks a lot, this is brilliant. Everything works fine now.

from stm32f1xx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.