gravity-bridge / gravity-docs Goto Github PK

View Code? Open in Web Editor NEW

62.0 62.0 141.0 5.83 MB

Genesis files and Documentation for the Gravity Bridge Blockchain

gravity-docs's Introduction

gravity-docs's People

Contributors

Stargazers

Watchers

Forkers

edouardlvdl goooodnes rognar9nok gadost pavelmoneyin davidistheuser 79anvi asergijenko k0kk0k paddyson79 ivlad-ko shivlim pug-queen rmadrona p2p-org dee-effes botd0tnet thepizzatech yasiryagi activenodes alfdidnothingwrong axcel42 ekaterinagorb djodjax mattharrop cyberomanov svv28 maxzonder caseyrweiss voynitskiy enterstake althaea-node kernelpanic9 maxfoton thosmos keni32 veeloup jjangg96 tonystarkman2 alexmed911 mt2721 aamironov vgk88 zhangmn88 alipostaci2001 aleksandr7793 bakon11 goto5k ovrclk alkadeta falconpmt oiseauleil rich518 projecttent airled jack2003jack kwunyeung solid-stake loa-labs alxnode yurbason dpdanpittman tasibali1 ivandiazperez stakinofficial randyramig anonstake qubelabsio venglov blitmore xela7 web3validator kristianjones ardapda chandrastation lightiv sunnya97 aditya-manit armyids wombatqq ramuchi cryptoperchik coriander-doc cardamonchik mediumwe11 ubikcapital kkemosabe dreamstaker vasya-kripto tedchun3 humantraffic ptts55 mchaker lampardlamps pngnjhnrgstr agenetworks wetezos kaustubhkapatral boycesm christianborst

gravity-docs's Issues

describe output of `gravity eth_keys add`

In the docs in this section it says to run gravity eth_keys add but doesn't describe why or the output.

An example would be helpful:

# create the Gravity Orchestrator Cosmos Key (private: in the command output
$ gravity eth_keys add

private: 0xce124acdcca17a5715aa61dfe64f5146a4a519b451134a759fe5124e89724fe3
public: 0x04f682c57545836570421227040c782fca11c546e518bc21720ade3d09c6fc3d9e8f0cd300a22189ac1737ded8dda8cdf55e5c477de9f6c131810e895837f3d522
address: 0xBb6a1d1a3737bD8d5c35224070EC22f22D861960

Are any of these the keys we need later? Is one of them the Gravity Orchestrator Cosmos Key Name that is needed in the next step? I think it's maybe the private key.

Are any of these keys important to keep private? Can someone steal my funds if they know them?

Also this command seems to create files in ~/.gravity but that's not mentioned in the documentation or the gravity eth_keys add --help

typo in orchestrator metrics

There is a typo ('r' is missing in orchestrator) in the following orchestrator metrics:

orchestator_information{gauge="latest_cosmos_block"} 490604
orchestator_warnings_count_eth{warn_message="Could not contact Eth node, trying again"} 129
orchestator_warnings_count_total 129

sailingbird gentx file

gentx-6b9b935f994433c9e4436399f40b7f41ebb4b95c.json.txt

"Confirm you are validating" section inconclusive

https://github.com/Gravity-Bridge/Gravity-Docs/blob/main/docs/setting-up-a-validator.md#confirm-that-you-are-validating

Says If you see one line in the response you are validating. If you don't see any output from this command you are not validating. Check that the last command ran successfully.

But what if you see multiple lines? Like this:

$ gravity query staking validator $(gravity keys show gravity1kppuvmyff24ey4hu7mct0kzskmrttsk8payzzl --bech val --address)
Enter keyring passphrase:
commission:
  commission_rates:
    max_change_rate: "0.010000000000000000"
    max_rate: "0.200000000000000000"
    rate: "0.100000000000000000"
  update_time: "2022-01-13T15:31:53.017127196Z"
consensus_pubkey:
  '@type': /cosmos.crypto.ed25519.PubKey
  key: 4dk12mGin1oh19f1xErDfn19g+W/pmzGqrVy5uDku1I=
delegator_shares: "1.000000000000000000"
description:
  details: ""
  identity: ""
  moniker: mymoniker
  security_contact: ""
  website: ""
jailed: false
min_self_delegation: "1"
operator_address: gravityvaloper1kppuvmyff24ey4hu7mct0kzskmrttsk8skaugt
status: BOND_STATUS_UNBONDED
tokens: "1"
unbonding_height: "0"
unbonding_time: "1970-01-01T00:00:00Z"

Document parameters to 'gravity keys add'

gravity keys add <my validator key name> --recover <your seed phrase>

Where do I get <my validator key name>? Is this my wallet address for my gravity bridge tokens?

What is the <your seed phrase>? Is that the mnemonic for my wallet?

If so, this seems kind of dangerous to give this info out here. If not, where do I find this info?

<your seed phrase> isn't used on the page anywhere else. Some description of what this is and what why it matters would be helpful. Like, keep his seed phrase, you'll need it later....

orchestrator.service missing gravity contract address

ExecStart should be:

ExecStart=/usr/bin/gbt orchestrator --fees "0ugraviton" --gravity-contract-address "0xa4108aA1Ec4967F8b52220a4f7e94A8201F2D906"

Or the docs should say to add this parameter...

What is a moniker?

In the docs it says:

gravity init mymoniker --chain-id gravity-bridge-2

What is mymoniker? Should it be unique per validator? Should it be unique globally among all validators? What if it's not unique? Will this cause a problem?

The `gravity keys add <Your Gravity Orchestrator Cosmos Key Name>` is confusing

In this section it mentions <Your Gravity Orchestrator Cosmos Key Name> but there is no indication where to get that. Might be better to say:

gravity keys add <Gravity Orchestrator Cosmos Key>
# <Gravity Orchestrator Cosmos Key> is the private key from the previous command

Drop the Your and the Name. Just say Gravity Orchestrator Cosmos Key. Also add that it's the private key generated by the previous command if that's actually true.

Formatting of description difficult to read.

https://github.com/Gravity-Bridge/Gravity-Docs/blob/main/docs/setting-up-a-validator.md#generate-your-delegate-keys

The 4 keys are described but the formatting doesn't wrap. Suggest using itemized list.

How do we know when GB and ETH are fully synced?

This doc says you will need to wait for your Gravity Bridge node and Ethereum Node to fully sync before progressing in the instructions

How do you know when it's synced?

Where do you get myvalidatrorkeyname

https://github.com/Gravity-Bridge/Gravity-Docs/blob/main/docs/setting-up-a-validator.md#send-your-validator-setup-transaction

Has a parameter called myvalidatorkeyname but that's not defined anywhere in the page. Where do we get that from?

define params `<my validator key name>` and `<your seed phrase>`

In this section you say:

gravity keys add <my validator key name> --recover <your seed phrase>

Where do I get these parameters?

is <my validator key name> one of the 4 keys mentioned below? If so, use the same name. Where do I get the <your seed phrase>? Is that something that I used before, like the mnemonic for my wallet? Or something else?

It would be helpful to understand why this command is being run. What's it doing?

Minor issues with setting-up-a-validator.md

Trying to set up a node following https://github.com/Gravity-Bridge/Gravity-Docs/blob/main/docs/setting-up-a-validator.md

Section: Add your validator key
No information on how to create new gravity bridge wallet keys (only gives --recovery and --ledger). Isn't clear that the only command needed is:
gravity keys add

Section: View your key (optional)
gives command: gravity keys show --bech val
Would be helpful to clarify that the way to get the wallet address to transfer from Keplr is
gravity keys show

Section: Setup Gravity Bridge and Orchestrator service
Line number references do not correspond to the *.service files that are currently downloaded at
wget https://raw.githubusercontent.com/Gravity-Bridge/Gravity-Docs/main/configs/

gravity-bridge / gravity-docs Goto Github PK

gravity-docs's Introduction

Documentation

High level documentation

Code documentation

Specs

Design docs

Developer Guide

Status

The design of Gravity Bridge

Key design Components

Operational parameters ensuring security

gravity-docs's People

Contributors

Stargazers

Watchers

Forkers

gravity-docs's Issues

Recommend Projects

Recommend Topics

Recommend Org