gravidao / old-lunar-assistant-bot Goto Github PK

Notes:

• Info on connecting with ledger
• More examples
• Credits

Instead of all or nothing, we should implement best effort for getWalletContents.

• in all or nothing mode, if there is an issue with one of the marketplaces then updates wont be possible until it is resolved.
• in best effort mode, if there is an issue with one of the marketplaces then all info is returned except for that broken marketplace. But this means users might lose roles while the marketplace is down. Ideally roles still get added but not removed to prevent users losing roles due to a broken marketplace.

Currently all of the lunar-configure command definitions are in a single file, but it would be nice to break them up into multiple files.

Currently ownership of an NFT is checked by querying the tokens of a user according to a specific smart contract.

Ideally we would move this validation approach off chain for performance reasons, potentially with the help of the randomearth nft indexer.

Upon community request and vote, the default response when running the lunar-view-roles command should be set to Private

Within lunar-assistant-bot/blob/main/src/commands/lunar-view-roles.ts

Change line 29:
const privateResponse = rawPrivateResponse ? rawPrivateResponse : false;
to
const privateResponse = rawPrivateResponse ? rawPrivateResponse : true;

Currently a user registers a wallet on the frontend and isn't given any information about the roles they are eligible for on Discord.

Instead, show the user what roles they are eligible on the frontend upon registering a wallet.

Resources:

• https://www.reddit.com/r/discordapp/comments/mregaf/restrict_different_bot_slash_commands_to_specific/
• https://groovy.zendesk.com/hc/en-us/articles/360060605411
• discord/discord-api-docs#2355
• discord/discord-api-docs#2324

Title is pretty much self-explanatory...
If the role name is changed after the configuration has been done, the bot doesn't work anymore...

This doesn't quite make any sense IMHO, as the bots should be agnostic of any human (re)naming action.

Should be an easy fix, but we need to understand what are the ramifications of doing such an update (what happens to the already configured roles everywhere until now).

Currently the configuration / functionality of Lunar Assistant is relatively limited. Each discord server can just specify a single contract from which to give roles based on the ownership of a single NFT.

Improve this system by using "rules". A server can configure multiple rules, each of which specifies a type of asset, a threshold quantity of that asset, and the role to be given upon a user meeting the threshold.

Right now a user's nft ownership if verified upon linking a wallet and then never again.

We should set up a process for removing roles from users who sell their nfts, and for adding roles to users that buy nfts.

Two possible approaches

• check the contents of every discord users wallet every X time interval (maybe everyday)
• listen to all transactions and check for those where NFTs change hands. make relevant role updates