Giter Club home page Giter Club logo

Comments (4)

narqo avatar narqo commented on May 29, 2024 1

[..] clearly document what the new restrictions are and why

It seems that the issue is an degradation effect of #7700.

Note there is a document, that lists the requirements for tenant ID. It has the subset of special characters, that are supported. @bobbeeke, which of those listed aren't working for your setup?

from mimir.

56quarters avatar 56quarters commented on May 29, 2024 1

Question marks in tenant IDs have never been allowed per the docs but this wasn't enforced when tenant federation was disabled until Mimir 2.12. Version 2.12 fixed this oversight.

PR: #6959
Changelog:

[CHANGE] Validate tenant IDs according to [documented behavior](https://grafana.com/docs/mimir/latest/configure/about-tenant-ids/) even when tenant federation is not enabled. Note that this will cause some previously accepted tenant IDs to be rejected such as those longer than 150 bytes or containing | characters. #6959

from mimir.

bobbeeke avatar bobbeeke commented on May 29, 2024

Clear, thanks for pointing out @narqo
I will change my X-Scope-OrgIDs.
It is however strange that until now I had no problem. I used random strings with all kind of characters and it did never complain.

Feel free to close this one if no further action is required.

from mimir.

narqo avatar narqo commented on May 29, 2024

Thank you, for having a look. If you further bump into an unexpected behaviour in the validation of the tenant's header, please re-open this one.

from mimir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.