gquintard / libvmod-accept Goto Github PK

The 4.1 branch requires varnish 5.0+ which causes ./configure to fail.

checking for Varnish... 4.1.11
configure: error: Varnish version 5.0 or higher is required.

Upon changing the VARNISH_PREREQ([5.0]) constraint in configure.ac it has been built successfully. Is it only the matter of a wrong constraint?

we just noticed that the accept rules we set for languages seem to be case sensitive. our backend is not case sensitive, so introducing this module broke some clients that sent an UPPERCASE language. we changed to accept_lang_rules.filter(std.tolower(req.http.Accept-Language)) to work around the issue, but i wanted to ask if this is designed like this on purpose or not. if its on purpose, i suggest to update the readme to mention that and maybe change the lang_rules example to use std.tolower.

master branch does not compile against Varnish 5.

checking for Varnish... 5.1.2
configure: error: Varnish version below 5.1 is required.

There is also no specific branch nor tag to work with this version, only master is available. Does the vmod support Varnish 5 at all?