gpupo / cache Goto Github PK

Defining the interface yourselves and replacing the original package is a bad idea, especially given that the phpdoc of your interfaces don't match the actual PSR (return values for most method are booleans, not a fluent interface).

Please either upgrade your package to actually respect PSR-6, or mark it as abandoned on Packagist so that people looking for a PSR-6 implement know that they should go elsewhere.

Is it possible to have a new release ? If there is something you'd like to be done before, please tell me and I'll help if I can

Hi @gpupo

any plans on updating the library to match the PSR-6 specs?

These two methods are missing in your implementation:

public function expiresAt($expiration);
@see https://github.com/php-fig/cache/blob/master/src/CacheItemInterface.php#L89

public function expiresAfter($time);
@see https://github.com/php-fig/cache/blob/master/src/CacheItemInterface.php#L104

Please let me know. I use your implementation in a demo and in unit-tests for https://github.com/clickalicious/caching-middleware but now the dependency is broken.

I can also do the work and send you a PR for the changes if u like.

Registrando aqui que o build desta lib não está passando: https://travis-ci.org/danielcosta/cache/builds/56599921