googlefonts / gf-glyphs-scripts Goto Github PK

View Code? Open in Web Editor NEW

21.0 33.0 11.0 97 KB

Scripts for Glyphs

Python 100.00%

gf-glyphs-scripts's Introduction

Glyphsapp QA and production scripts for Google Fonts

qa.py

Check a font family conforms to the Google Fonts' specification

Installation

Open Glyphsapp and type command + shift + y
Drag Google Fonts folder into Scripts folder

FontTools must be installed. This can be installed by going to Glyphs > Preferences > Addons > Install Modules

gf-glyphs-scripts's People

Contributors

Stargazers

Watchers

Forkers

m4rc1e dsweetnich cclauss mjlagattuta yanone paulyc weiweihuanghuang kosbarts manlix isabella232 rdela

gf-glyphs-scripts's Issues

Fix script broken

Traceback:

Start
Traceback (most recent call last):
  File "fixfonts.py", line 264, in <module>
    main()
  File "fixfonts.py", line 250, in main
    ttfs_gf = download_gf_family(font.familyName)
  File "/Users/dcrossland/src/github.com/googlefonts/gf-glyphs-scripts/Google Fonts/utils.py", line 66, in download_gf_family
    return fonts_from_zip(family_zip)
  File "/Users/dcrossland/src/github.com/googlefonts/gf-glyphs-scripts/Google Fonts/utils.py", line 58, in fonts_from_zip
    ttfs.append(TTFont(zipfile.open(file_name)))
  File "/Library/Python/2.7/site-packages/fonttools-3.25.0-py2.7.egg/fontTools/ttLib/ttFont.py", line 126, in __init__
    file.seek(0)
io.UnsupportedOperation: seek
End

io.UnsupportedOperation: seek

macOS 10.13.6
GA Version 2.5.2 (1176)
fontTools "3.31.0"

Traceback (most recent call last):
  File "fixfonts.py", line 265, in <module>
    main()
  File "fixfonts.py", line 250, in main
    ttfs_gf = download_gf_family(font.familyName)
  File "~/Library/Application Support/Glyphs/Scripts/gf-glyphs-scripts-master/Google Fonts/utils.py", line 66, in download_gf_family
    return fonts_from_zip(family_zip)
  File "~/Library/Application Support/Glyphs/Scripts/gf-glyphs-scripts-master/Google Fonts/utils.py", line 58, in fonts_from_zip
    ttfs.append(TTFont(zipfile.open(file_name)))
  File "~/Library/Application Support/Glyphs/Scripts/fontTools/ttLib/ttFont.py", line 127, in __init__
    file.seek(0)
io.UnsupportedOperation: seek

unencoded missing glyphs check

Following #15 (comment) chek unencoded glyphs missing from previous release, plus OT checks, and mention OT features on the spec

fixfonts.py: NameError: global name '_convert_camelcase' is not defined

Traceback (most recent call last):
  File "fixfonts.py", line 264, in <module>
    main()
  File "fixfonts.py", line 226, in main
    family_suffix = _convert_camelcase(instance.width)
NameError: global name '_convert_camelcase' is not defined
End

Check for and set "Write Kern Table" Custom Parameter

Details: https://forum.glyphsapp.com/t/old-style-kern-table-export/3322

Can fix-nonhinting be moved into .glyphs Custom Parameters?

https://github.com/Lacquer-Font/Lacquer/pull/1/files#diff-2a16a4efc5dc106a1a3df65f51a852ceR9

Can that be avoided by placing 2 custom parameters to set the GASP and PREP table values within glyphsapp files?

Check for duplicate outlines

Similar to fonttools/fontbakery#1954 we could check for this within GlyphsApp

Style Linking Issues

Is there a recommendations guide on style linking?

I ran the QA script in gf-glyphs-scripts and I'm getting a few errors I don't understand (my setup currently is that I have 1 set of instances for OTF, and 1 set for Webfonts with different vertical metric schemes, I also have a set for Italics, with the same vertical metrics as the TTF).

Firstly I had every italic instance linked to its upright counterpart, then I had "Bold" linked as Bold then "Bold Italic" as the Bold-Italic of Regular, I got these issues:

================================================================================
FAIL: Check style linking is correct for italic instances
--------------------------------------------------------------------------------
Italic instance must have no style linking.
Delete link to Regular

================================================================================
FAIL: Check style linking is correct for non italic instances
--------------------------------------------------------------------------------
Bold instance must have no style linking. Delete link to Regular

So I remove the linking in the "Italic" instance (why is that the case that every other weight should have Italic linking but not the 400 Regular Italic [named "Italic"]?)

Then I remove the style linking in the "Bold" instances. But keep the linking in the "Bold Italic" (this seems inconsistent). Now I get more issues:

================================================================================
FAIL: Check only Bold and Bold Italic have 'isBold' set
--------------------------------------------------------------------------------
'Bold' instance is a Bold weight.
Enable "Bold of" for this instance.

================================================================================
FAIL: Check only italic instances have 'isItalic' set
--------------------------------------------------------------------------------
'Italic' instance is an Italic.
Enable 'Italic of' for the instance

================================================================================
FAIL: Check style linking is correct for italic instances
--------------------------------------------------------------------------------
Italic instance must have no style linking.
Delete link to None

================================================================================
FAIL: Check style linking is correct for non italic instances
--------------------------------------------------------------------------------
Bold instance must have no style linking. Delete link to None

Confusingly, now the script is returning that in fact the "Bold" instance should be enabled as Bold (of Regular?), same with "Italic" as Italic. While at the same time returning Italic must have no style linking?

I have run the script on this file

Copyright string check / OFL copyright mismatch error

I get the following error when running QA from Glyphs (Version 2.5.1 (1141)) "OFL.txt and font copyright do not match." when as far as I can tell, they are functionally the same. Have checked for hidden characters etc; and not found anything amiss. Copyright is on first line of OFL.txt.

Strings in question below;

OFL copyright: Copyright 2018 The Turret Road Project Authors (https://github.com/noponies/turret-road)
Font copyright: Copyright 2018 The Turret Road Project Authors (https://github.com/noponies/turret-road)

Integrate "Why You Not Compatible?"

How to integreat https://github.com/simoncozens/GlyphsScripts/blob/master/Why%20You%20Not%20Compatible.py ? :)

Copyright notice check has incorrect assumption about date

gf-glyphs-scripts/Google Fonts/qa.py

Lines 192 to 208 in f93799f

 self.assertIsNotNone( 

 copyright_search, 

 ('Copyright string is incorrect.\n\n' 

 'It must contain or be:\n' 

 'Copyright %s The %s Project Authors (%s)\n\n' 

 'If the family has a RFN:\n' 

 'Copyright %s The %s Project Authors (%s), ' 

 'with Reserved Font Name "%s".') % ( 

 datetime.now().year, 

 font.familyName, 

 repo_git_url, 

 datetime.now().year, 

 font.familyName, 

 repo_git_url, 

 font.familyName, 

 ) 

 )

This check is wrong, the copyright date should be the earliest date that the project started, not the current date. There is likely no way to check that date programmatically, so a regex that checks for 4 digits making the year is sufficient (likely started 19 or 20 :)

Add versioning

There's no versioning for this repo. I suggest we adopt the standard semver approach.

Copyright string check is a Grammar Na..i

Font:
Copyright 2015 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC)

OFL:
Copyright 2015 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC)

QA spits out:

Copyright string is incorrect.

It must contain or be:
Copyright 2017 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC.git)

If the family has a RFN:
Copyright 2017 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC.git), with Reserved Font Name "Amatic SC".

I think keeping earliest mention year is fine, no?

Update scripts so they will work properly on VFs with multiple axes

I think I've sorted the VF instance name/stat table issue for variable fonts with multiple axes. Once Dave has confirmed he's happy, we can update the scripts in this repo.

git ignore .pyc files

vertmetrics.pyc shouldn’t be there.

Initial Setting of Vertical Metrics

When I run this script, it doesn't set typoAscender or hheaAscender?

Date attribute parameter check generates false positive

QA test creates a false positive in cyrealtype/Lora-Cyrillic@02e0832

================================================================================
FAIL: Check all .glyph files share same parameters
--------------------------------------------------------------------------------
Files do not have equal attribute parameters.

Lora-Italic.glyphs date: 2017-10-27 16:56:35 +0000
Lora.glyphs date: 2017-10-27 16:55:49 +0000

================================================================================
FAIL: Check single weight families have Regular style name
--------------------------------------------------------------------------------
'Italic' instance name is incorrect.

Families which have just one instance must name the single 'Regular'

The family consists of two styles, Regular and Italic. Each style has its own .glyphs file.

	self.assertIsNotNone(
	copyright_search,
	('Copyright string is incorrect.\n\n'
	'It must contain or be:\n'
	'Copyright %s The %s Project Authors (%s)\n\n'
	'If the family has a RFN:\n'
	'Copyright %s The %s Project Authors (%s), '
	'with Reserved Font Name "%s".') % (
	datetime.now().year,
	font.familyName,
	repo_git_url,
	datetime.now().year,
	font.familyName,
	repo_git_url,
	font.familyName,
	)
	)