Sync with manual mapping not working when multiple files are changed of which the first one is not mapped about skaffold HOT 2 OPEN

I was able to reproduce this bug by making a simple change to the appropriate unit test: simonstratmann@96f5432

I don't know Go at all and can't begin to comprehend how to fix this bug, though. Perhaps I'm misunderstanding the idea behind manual sync but with a change event with multiple files why would each file have to match the sync patterns.

I think that pkg/skaffold/sync/sync.go:228 (intersect) should not return as soon as a file does not match. I tried replacing return nil, nil with continue which actually fixed my problem but made many of the other manual tests fail. I'm sure if you know what you're doing this is easy to fix.

from skaffold.

I was actually able to fix the bug and keep the other tests successful. I added a dirty hack for the latter because the expectations should probably be different.

from skaffold.