Expected behavior When I: have <code clas

Dockerfile in .dockerignore is not respected, leading to unnecessary full rebuilds about skaffold HOT 2 OPEN

ComaVN commented on September 22, 2024

Dockerfile in .dockerignore is not respected, leading to unnecessary full rebuilds

from skaffold.

Comments (2)

ComaVN commented on September 22, 2024

Note that other files in .dockerignore are properly ignored.

from skaffold.

ComaVN commented on September 22, 2024

I just noticed another difference between docker build . and skaffold build: it seems that skaffold does NOT copy the .dockerignore file, while docker build does! It's not even possible to do COPY .dockerignore . using skaffold (although I'm not sure why you'd ever want that).

$ docker build .
(...)
 > [builder 4/5] RUN ls -la ; false:                                                                                                                                                          
0.117 total 32                                                                                                                                                                                
0.117 drwxr-xr-x 1 root root 4096 May  2 12:08 .                                                                                                                                              
0.117 drwxr-xr-x 1 root root 4096 May  2 12:08 ..                                                                                                                                             
0.117 -rw-rw-r-- 1 root root   11 May  2 12:00 .dockerignore                                                                                                                                  
0.117 -rw-rw-r-- 1 root root  571 Mar 14 12:48 README.md
0.117 -rw-rw-r-- 1 root root   82 Mar 14 12:48 go.mod
0.117 -rw-rw-r-- 1 root root  133 Mar 14 12:48 k8s-pod.yaml
0.117 -rw-rw-r-- 1 root root  128 Mar 14 12:48 main.go
0.117 -rw-rw-r-- 1 root root  130 May  2 11:56 skaffold.yaml

$ skaffold build
(...)
Step 4/10 : RUN ls -la ; false
 ---> Running in 444c2c1e6f30
total 32
drwxr-xr-x 1 root root 4096 May  2 12:09 .
drwxr-xr-x 1 root root 4096 May  2 12:09 ..
-rw-rw-r-- 1 root root  470 May  2 12:05 Dockerfile
-rw-rw-r-- 1 root root  571 Mar 14 12:48 README.md
-rw-rw-r-- 1 root root   82 Mar 14 12:48 go.mod
-rw-rw-r-- 1 root root  133 Mar 14 12:48 k8s-pod.yaml
-rw-rw-r-- 1 root root  128 Mar 14 12:48 main.go
-rw-rw-r-- 1 root root  130 May  2 11:56 skaffold.yaml

Diff with getting-started example:

diff --git a/examples/getting-started/.dockerignore b/examples/getting-started/.dockerignore
new file mode 100644
index 000000000..94143827e
--- /dev/null
+++ b/examples/getting-started/.dockerignore
@@ -0,0 +1 @@
+Dockerfile
diff --git a/examples/getting-started/Dockerfile b/examples/getting-started/Dockerfile
index 67f8c3cbb..3798e28db 100644
--- a/examples/getting-started/Dockerfile
+++ b/examples/getting-started/Dockerfile
@@ -1,7 +1,7 @@
 FROM golang:1.18 as builder
 WORKDIR /code
-COPY main.go .
-COPY go.mod .
+COPY . .
+RUN ls -la ; false
 # `skaffold debug` sets SKAFFOLD_GO_GCFLAGS to disable compiler optimizations
 ARG SKAFFOLD_GO_GCFLAGS
 RUN go build -gcflags="${SKAFFOLD_GO_GCFLAGS}" -trimpath -o /app main.go

from skaffold.

Recommend Projects