Giter Club home page Giter Club logo

Comments (9)

ericzzzzzzz avatar ericzzzzzzz commented on May 25, 2024 1

closing this as #9278 is merged. @idsulik thank you for the fix!

from skaffold.

ath88 avatar ath88 commented on May 25, 2024

I am seeing the same regression after upgrading to v2.10.

Content of skaffold.yaml is:

apiVersion: skaffold/v4beta8
kind: Config
metadata:
  name: example
build:
  artifacts:
    - image: example
      context: container
deploy:
  helm:
    releases:
      - name: chart
        chartPath: chart
        setValueTemplates:
          image: localhost:5000/example:{{.IMAGE_TAG_example}}@{{.IMAGE_DIGEST_example}}

When making changes in container/Dockerfile (such as adding a RUN lsor similar), I will get the following output:

Generating tags...
 - example -> localhost:5000/example:123b516-dirty
Checking cache...
 - example: Found Remotely
Tags used in deployment:
 - example -> localhost:5000/example:123b516-dirty@sha256:eaca7009de6bf883b897623a31d3443449a59aed42a6fb030d9c2b009149c727
Starting deploy...

So there is no rebuild, which there was when using skaffold v2.9.

from skaffold.

aran avatar aran commented on May 25, 2024

@ath88 - are you using Bazel? If not, I will generalize the title of the issue.

from skaffold.

bhack avatar bhack commented on May 25, 2024

Same here without bazel

from skaffold.

idsulik avatar idsulik commented on May 25, 2024

Looks like it's this issue #9248
Trying to fix it here #9278

from skaffold.

bhack avatar bhack commented on May 25, 2024

I think a patch release is require as the regression was quite relevant.

from skaffold.

noorul avatar noorul commented on May 25, 2024

I still see this issue with 2.10.1

from skaffold.

noorul avatar noorul commented on May 25, 2024

@ericzzzzzzz Can we re-open this?

from skaffold.

idsulik avatar idsulik commented on May 25, 2024

@noorul , the fix is here #9306

from skaffold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.