Giter Club home page Giter Club logo

core-menu's Introduction

core-menu's People

Contributors

addyosmani avatar cdata avatar codemonkey800 avatar dfreedm avatar frankiefu avatar jakemac53 avatar sorvell avatar tjsavage avatar vikasprogrammer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

core-menu's Issues

Click doesn't trigger selectedItemChange if items are repositioned in core-menu

Suppose x-menu uses a core-menu but always shows the selected item at the top of the list:

<polymer-element name="x-menu" noscript>
  <template>
    <core-menu>
      <content select="core-item.core-selected"></content>
      <content select="core-item"></content>
    </core-menu>
  </template>
</polymer-element>

<x-menu>
  <core-item>Item 1</core-item>
  <core-item>Item 2</core-item>
  <core-item>Item 3</core-item>
  <core-item>Item 4</core-item>
</x-menu>

Click the third item (Item 3), so core-selector.selected is "2". Then click the third item again (Item 2). The selected item does not change; Item 3 is still ".core-selected". The "selected" attribute is set to 2 so it isn't considered a changed property.

Missing required a11y aria labels

  1. Use appropriate aria roles for elements, e.g. role="menu" and role="menuitem". Elements currently use confusing roles like "img" or are missing roles.
  2. Use meaningful aria labels, e.g. "arrow-drop-down" is too generic.
  3. Use aria-activedescendant property for the actively selected menu item.

Nested submenus don't work in IE9

When you nested ` in IE9, it has various failure modes. Here's a barebones example of nested submenus (it's in branch "nested-submenus" if you check it out).

In that example, if you open up submenu 1, then 1A, only the first item from 1A shows up (it has three children, all <core-item>s).

If you open up 1, then 1B, none of the children show up (there should be three <core-item>s).

I can put the example up on a server if checking it out is a pain.

Prevent update to selected attribute until confirmed

I've got a core-menu nested in paper-action-dialog > div > paper-dropdown-menu > paper-dropdown that I'm using to filter results from Firebase. Is there a way to keep it from updating the selected attribute until after the paper-action-dialog's affirmative button is tapped/clicked?

Don't responds on click in firefox

i can reproduce it in firefox 34 and 35beta (using clean profile).
for example on this page: https://www.polymer-project.org/components/core-elements/demo.html
or https://www.polymer-project.org/components/core-menu/demo.html

nothing happens when clicking on item, no any exceptions in console

in chrome it works as expected

UPD: also tested on firefox ESR 31 and the same behavior.
paper-tabs have almost the same behavior -- animation plays on click, but nothing more happens (and no any exceptions too)

UPD2: firefox nightly 37 -- the same behavior

UPD3: it don't reproduces in 0.4.2, problem started to reproduce only on 0.5.0 and the later versions.
i found only two commits between 0.4.2 and 0.5.0 (one of them to demofiles) and other is to deps:
5fdc874 . so that seems to be a problem in core-selector which came there from core-selection and which came there from polymer itself

Create disabled items

Is there a way to create a disabled menu item?
That is shown but not selectable ?

I'm using a core-menu with a few core-submenu all containing paper-items.
What I want to do is to add a to make is unselectable but still show in the menu and then CSS it to be greyed out.

Tree functionality

I've been trying to use core-menu/core-submenu as a tree, and there are many problems. Before I start an elaborate writeup, I'd like an see to know

  • Is using core-menu as a tree part of intended functionality or not?
  • If not, are you planning on core-tree?

My suggestion is to add a tree property to core menu, and make it work. Tree is visually identical, only behavior differs.

Selecting core-submenu core-item deselects that menu item when multi attribute is set to true

I have a menu with submenu and those submenus have nested submenus and when the item in the nested submenus are clicked the core-select event is triggered with the submenu no longer being selected. This only happens when "multi" is set to true

<core-menu multi="true">
   <core-submenu icon="check-box-outline-blank" label="Submenu 1">
      <core-item icon="check-box-outline-blank" label="Item 1"> </core-item>
      <core-item icon="check-box-outline-blank" label="Item 2"> </core-item>
      <core-submenu icon="check-box-outline-blank" label="Sub-Sub-Menu 1">
          <core-item icon="check-box-outline-blank" label="Item 1"> </core-item>
          <core-item icon="check-box-outline-blank" label="Item 2"> </core-item>
     </core-submenu>
   </core-submenu>
   <core-submenu icon="check-box-outline-blank" label="Submenu 2">
      <core-item icon="check-box-outline-blank" label="Item 1"> </core-item>
     <core-item icon="check-box-outline-blank" label="Item 2"> </core-item>
   </core-submenu>
</core-menu>

Cannot set 'font-scalable' on core-submenu.core-item

With core-item you can set class="font-scalable" which will make all measurements in "em"s, which allows for resizing menu items (and their padding), but it isn't possible to to set this attribute on <core-submenu> and propagate it through to its implicit <core-item>.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.