Comments (2)
@bjwatson After discussing with @lukesneeringer, I'm opposed to this for a few reasons, mostly related to proto dependencies:
- It requires
artman
ANDtoolkit
to know not only about the GAPIC config for the API it is generating, but about all GAPIC configs in existence (since protos can import arbitrary other protos) - A change the configured GAPIC package name in one API potentially entails breaking changes across any API that depends on its protos
- We don't have any good way to handle protos for APIs where there is no GAPIC wrapper, since there is no GAPIC config. Furthermore, introducing a GAPIC config down the road for those protos is a breaking change to any API that relies on them
- It's much more complex to implement this than the currently logic, since both
artman
andtoolkit
need to have a mechanism to assign to each proto a single GAPIC config. No such mechanism exists. What happens if two different GAPIC configs list the same proto under their sources?
from artman.
Per offline discussion with @lukesneeringer and @bjwatson, the current state of things will be maintained. In summary:
- The package name that appears on PyPI (e.g.,
proto-google-cloud-errorreporting-v1beta1
andgapic-google-cloud-errorreporting-v1beta1
) will be consistent and derived only from the artman config. - The package path within these PyPI packages (e.g.,
google.cloud.proto.devtools.clouderrorreporting
,google.cloud.gapic.errorreporting
) may be inconsistent because the Python-language proto package is derived from the proto-language proto package, and the GAPIC package is derived from the GAPIC config.
from artman.
Related Issues (20)
- Missing input file. should be more descriptive HOT 7
- Go: run goimports as part of artman script HOT 15
- Go: release level not being considered HOT 3
- Switch to composer from pear for PHP dependencies HOT 5
- Python: include enums in generated documentation HOT 5
- Error while finding module specification for 'grpc_tools.protoc' (ModuleNotFoundError: No module named 'grpc_tools') HOT 6
- Typos in CONTRIBUTING.rst
- Nested package proto imports fail for Python HOT 2
- --local runs are broken HOT 3
- Samples are not being generated (as of 0.29.1) HOT 3
- Add sample generation to golden test (to catch samplegen regressions) HOT 2
- artman: pull the artman image for me HOT 4
- module has no attribute FullLoader HOT 1
- mysterious error HOT 1
- un-whitelist monitoring
- Java: update protoc plugin
- fix cel API generation HOT 4
- allow passing extra command line options to protoc HOT 1
- Does not work on the github.com/google/fhir protobufs?
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artman.