Comments (3)
alexander-fenster
commented on June 12, 2024
@hzyi-google so since @andreamlin is out, do you think you'll have bandwidth to fix it, or should I just go ahead and do it? We do have folks using --local so they will complain soon I guess.
Also, I don't like the idea that the .sh script is being parsed in Python to extract the version numbers; I'd better refactor the version numbers away from the shell script but it's out of scope of this issue.
from artman.
yihanzhen
commented on June 12, 2024
Hey Alex,
If you have time please go ahead and fix it. I am on vacation for the rest
of the week and the entire week next week.
Thanks,
Hanzhen
…On Thu, Jun 20, 2019, 15:00 Alexander Fenster ***@***.***> wrote:
@hzyi-google <https://github.com/hzyi-google> so since @andreamlin
<https://github.com/andreamlin> is out, do you think you'll have
bandwidth to fix it, or should I just go ahead and do it? We do have folks
using --local so they will complain soon I guess.
Also, I don't like the idea that the .sh script is being parsed in Python
to extract the version numbers; I'd better refactor the version numbers
away from the shell script but it's out of scope of this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#649?email_source=notifications&email_token=AIBMYD6MQZBDTBBMOR7GP2TP3P4YHA5CNFSM4HZ7YP72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYG3PJQ#issuecomment-504215462>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIBMYD5SQLV47LPVOQGYCJLP3P4YHANCNFSM4HZ7YP7Q>
.
from artman.
vam-google
commented on June 12, 2024
@alexander-fenster I'm wondering why that change was introduced. It looks like older version used by java was the case. Why didn't we just bumped the java protoc and grpc version, instead of doing that change. I would strongly consider reverting the change, as it complicates the system even more
from artman.
Related Issues (20)
- Missing input file. should be more descriptive HOT 7
- Go: run goimports as part of artman script HOT 15
- Go: release level not being considered HOT 3
- Switch to composer from pear for PHP dependencies HOT 5
- Python: include enums in generated documentation HOT 5
- Error while finding module specification for 'grpc_tools.protoc' (ModuleNotFoundError: No module named 'grpc_tools') HOT 6
- Typos in CONTRIBUTING.rst
- Nested package proto imports fail for Python HOT 2
- Samples are not being generated (as of 0.29.1) HOT 3
- Add sample generation to golden test (to catch samplegen regressions) HOT 2
- artman: pull the artman image for me HOT 4
- module has no attribute FullLoader HOT 1
- mysterious error HOT 1
- un-whitelist monitoring
- Java: update protoc plugin
- fix cel API generation HOT 4
- allow passing extra command line options to protoc HOT 1
- Does not work on the github.com/google/fhir protobufs?
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artman.