Comments (10)
metaflow
commented on June 11, 2024
it was not skipped randomly: https://buildkite.com/llvm-project/diff-checks/builds/166609#0187a3da-cb41-4dde-9449-fef46cd5835e
if there is another build triggered for the same diff we cancel the previous one as not interesting. I believe we specifically added this feature, maybe even with you.
I have updated the report and now it will report skipped build as a failure to Phabricator, I assume that the next "new" build will update status on phabricator correctly.
from llvm-premerge-checks.
ldionne
commented on June 11, 2024
if there is another build triggered for the same diff we cancel the previous one as not interesting. I believe we specifically added this feature, maybe even with you.
Yes, I know that and I remember, but in the case I am referring to, there was no other build started after the one that got skipped. Is it possible that what happened is that we would update the patch, a new job would fail to be created, but we'd still cancel the previous one? Then the cancelled job would finish (as a success because we just skip the libcxx pipeline) and we'd report that to Phabricator, which is basically a confusing result.
from llvm-premerge-checks.
metaflow
commented on June 11, 2024
I think that the job got cancelled based on branch name - so we should have
executed the diff application. as a disclaimer - I have not tested the
updated code in skip scenario and would appreciate if you tell if it is
still broken or not
…On Thu, May 4, 2023, 20:26 Louis Dionne ***@***.***> wrote:
if there is another build triggered for the same diff we cancel the
previous one as not interesting. I believe we specifically added this
feature, maybe even with you.
Yes, I know that and I remember, but in the case I am referring to, there
was no other build started after the one that got skipped. Is it possible
that what happened is that we would update the patch, a new job would fail
to be created, but we'd still cancel the previous one? Then the cancelled
job would finish (as a success because we just skip the libcxx pipeline)
and we'd report that to Phabricator, which is basically a confusing result.
—
Reply to this email directly, view it on GitHub
<#445 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6EOY64VEI44355BUVTFTXEPYDXANCNFSM6AAAAAAXVYZSEY>
.
You are receiving this because you commented.Message ID:
***@***.***>
from llvm-premerge-checks.
ldionne
commented on June 11, 2024
Is that deployed yet?
from llvm-premerge-checks.
metaflow
commented on June 11, 2024
aha
…On Thu, May 4, 2023, 23:37 Louis Dionne ***@***.***> wrote:
Is that deployed yet?
—
Reply to this email directly, view it on GitHub
<#445 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6EO4M253YSRGTLCIVKA3XEQOR7ANCNFSM6AAAAAAXVYZSEY>
.
You are receiving this because you commented.Message ID:
***@***.***>
from llvm-premerge-checks.
ldionne
commented on June 11, 2024
Ah, I see it's live indeed. From https://reviews.llvm.org/D138680:
The new implementation surfaces all the jobs in the Phabricator UI, including those that didn't run (e.g. because a previous step failed). This is a bit unwieldy -- would it be difficult to have a single link to the libcxx pipeline instead? There all the jobs are already presented in an aggregated form.
from llvm-premerge-checks.
metaflow
commented on June 11, 2024
right that's too spammy, I will update this tomorrow.
…On Thu, May 4, 2023, 23:53 Louis Dionne ***@***.***> wrote:
Ah, I see it's live indeed. From https://reviews.llvm.org/D138680:
[image: Screenshot 2023-05-04 at 5 51 12 PM]
<https://user-images.githubusercontent.com/700834/236337730-57f8052c-73b7-4bd3-b35a-2418254b0ed4.png>
The new implementation surfaces all the jobs in the Phabricator UI,
including those that didn't run (e.g. because a previous step failed). This
is a bit unwieldy -- would it be difficult to have a single link to the
libcxx pipeline instead? There all the jobs are already presented in an
aggregated form.
—
Reply to this email directly, view it on GitHub
<#445 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6EO7BQ6RPAPVMXTOYEKLXEQQOLANCNFSM6AAAAAAXVYZSEY>
.
You are receiving this because you commented.Message ID:
***@***.***>
from llvm-premerge-checks.
metaflow
commented on June 11, 2024
updated, now it will only tell about "libcxx CI FAILED"
from llvm-premerge-checks.
metaflow
commented on June 11, 2024
@ldionne is it better now?
from llvm-premerge-checks.
ldionne
commented on June 11, 2024
Yes, this is much better now, we can just click on the link and it takes us to the build, which is great. Thanks!
from llvm-premerge-checks.
Related Issues (20)
- buildkite build premerge-checks 98677 HOT 5
- Proposal for new pre-merge check: Enforce library layering constraints
- Please add libc++ and lldb to the precommit CI pipeline for Clang HOT 14
- Precommit CI is broken again (libomptarget) HOT 4
- Precommit says bazel is failing, looks to be a config issue
- git-clang-format crash on x64_debian
- Windows Precommit CI was not updated for the recent base LLVM language version change? HOT 2
- Precommit CI appears to be entirely broken HOT 4
- clang-format debian clang pre-commit failure for changes on libcxx.
- Patch failure due to git issue
- buildkite build premerge-checks 141874 HOT 1
- The Buildkite <-> Phabricator bridge can ignore failed tests in the "unit tests" view of Harbormaster HOT 9
- buildkite build diff-checks 161247 HOT 1
- [AIX][32, 64 bit]Buildkite premerge checks for AIX 32, 64 bit not working due to insufficient space on filesystem HOT 5
- [libcxx] Generated output step is failing because of IndentationError HOT 2
- "create branch" steps takes > 15min
- timeouts are reported as success HOT 3
- [libcxx] Generated Output step of libcxx fails on premerge checks HOT 3
- buildkite build phabricator-run-tests 174016 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from llvm-premerge-checks.