Please add libc++ and lldb to the precommit CI pipeline for Clang about llvm-premerge-checks HOT 14 CLOSED

Happened exactly the same thing to me on this MR / commit as well: https://reviews.llvm.org/D112374

A big patch with a lot of test churn got reverted, which is time consuming to maintain out of tree.

I got no prior notification, the project affected (lldb) does no pre-commit testing, and I have been spending a lot of time trying to even get the project to build correctly and run that test on my machine.

That project requires many dependencies and the build system setup is quite fragile... I completely agree it's unreasonable.

Reading the logs from the bot test failure, I would say I am 99% confident the test expectation change required is identical to many others in the commit.

from llvm-premerge-checks.

as I reading initial post - Aaron is asking to start lldb / libc++ pipelines when clang is updated. This is possible to configure.

from llvm-premerge-checks.

Thank you for the report! Looking on dependency setup: we already have a logic to run tests on all affected projects. The only issue is that lldb was excluded from being executed as it have been constantly failing or flaking. Do you know if situation has improved?

from llvm-premerge-checks.

Do you know if situation has improved?

I honestly have no idea regarding lldb. I know I've seen at least one test of theirs that's been flakey (from watching bots in IRC), but I would argue that such tests should be disabled regardless (if the test is so unstable we consider not adding the entire test suite to precommit CI, it's a low value test).

from llvm-premerge-checks.

Is there an update on this request. I would love Clang to test libc++ since we had some Clang changes affecting libc++ recently. Do you need assistance to setup testing libc++ with Clang?

from llvm-premerge-checks.

This was done in https://reviews.llvm.org/D137759, but we would really like to move from our own libc++ runners to Clang-dedicated runners. @metaflow how do you get your clang-dedicated runners? Could we get some with a specific Docker image installed on them?

from llvm-premerge-checks.

yes, we use a docker image containers/agent-builkite-debian. I have not updated them in a while..

from llvm-premerge-checks.

@ldionne after re-reading comments I think I misunderstood you. Do you want to run a new set of agents with a different setup?

from llvm-premerge-checks.

why it's not possible to use the same setup for "normal" linux and libc++?

from llvm-premerge-checks.

as I reading initial post - Aaron is asking to start lldb / libc++ pipelines when clang is updated.

That's correct @metaflow -- my goal is to alert folks working on Clang when we've made a change that impacts libc++ or lldb before the author commits the patch.

from llvm-premerge-checks.

I think that's what you need ⬆️ - now when clang is touched libcxx / libcxxabi projects will also be checked. That does not affect behavior of libcxx runners

from llvm-premerge-checks.

Thank you! Is it possible to also do lldb as well?

Also, is the FIXME comment still accurate there? (# FIXME: not sure about 'libcxx' and 'libcxxabi')

from llvm-premerge-checks.

added lldb and removed fixme

from llvm-premerge-checks.

Thank you!

from llvm-premerge-checks.