Giter Club home page Giter Club logo

discussion's Introduction

Discussion

FAQ

How do I suggest an improvement, ask a question or report an issue?

If you want to do anything from above, just create a new issue at the Issues section . Please be constructive and on-topic. In case you are reporting an issue either here, or at some specific app's repository, please give as much useful information as possible, ideally with steps to reproduce. Being able to reproduce a bug and understand it can really speed up the fixing.

How can I suggest an edit to a file?

Creating pull requests with some changes is a lot simpler than most people think. Most suggestions are related to the translated strings, the steps are as follows:

  1. log in to Github
  2. find the file with the strings (app/src/main/res/values(-xx)/strings, for example the Italian translation of the PlayBooks is at https://github.com/Goodwy/PlayBooks/blob/master/core/src/main/res/values-it/strings.xml
  3. click the pencil button at the top right corner of the file
  4. edit the file with your suggestions*
  5. add a commit message under the file, to the textfield which has a hint similar to "Update strings.xml". Just type in what have you done, for example "updating spanish strings".
  6. click Propose file change
  7. click the green button Create pull request
  8. thank yourself!

* Change only the string which is between ">" and "</string>", not the first one after the "name=" tag, also not the strings between "<!--" and "-->"
* Please escape apostrophes, meaning you have to put a backslash before every apostrophe to make it look like: \'

For finding the proper language file at the PlayBooks go to https://github.com/Goodwy/PlayBooks/tree/master/core/src/main/res, then look for a "values-[language code]" folder. Use the strings.xml file inside it. If you can't find your language code, the file might not be translated to your language at all yet and you will have to create the whole new file.

How do I add a new file?

You will most likely want to add a new file only if you translate an app in a new language. Doing it is actually not difficult at all, just read on.

  1. log in to Github
  2. find the place where the new file belongs. If it's really a translation of the strings in a new language, go to app/src/main/res, for example https://github.com/Goodwy/PlayBooks/tree/master/core/src/main/res
  3. at the top right corner click at Create new file
  4. after the res folder you can type in your folder path. For creating a German translation just type in values-de/ (where de is the country code). The new folder will be added automatically after typing the slash.
  5. add a file name, i.e. strings.xml (the path should look similar to the image below)Github new file path
  6. copy the contents of an already existing strings.xml file into the new file (for example the content of https://github.com/Goodwy/PlayBooks/blob/master/core/src/main/res/values/strings.xml)
  7. add your string translations*
  8. add a commit message under the file, to the textfield which has a "Create new file" hint. Just type in what have you done, for example "adding spanish strings".
  9. press Propose new file
  10. click the green button Create pull request
  11. thank yourself!

* Change only the string which is between ">" and "</string>", not the first one after the "name=" tag.
* Please escape apostrophes, meaning you have to put a backslash before every apostrophe to make it look like: \'

discussion's People

Contributors

goodwy avatar

Stargazers

Maxi avatar SagXD avatar  avatar  avatar

Watchers

 avatar

discussion's Issues

Bookmarks annoying to make

As the bookmarks are annoying to make I'd like to request an option for setting a standard name.
For example:
It would rally help me because I don't care about the name of my bookmark if it just brings me to the point where I stopped listening. You could just make it so you can change the name afterwards. Thanks for your attention.

Thanks for your great work,
keep it up.

Feture request

Have an option to set a specific image as background on right dialer

[FEATURE] Many features for better app

First of all, hey Goodwy! Thanks for this amazing project and I'm fairly new to Android app development and would love to contribute in my free time.

Some of the amazing features that would be great to see in the apps which could get basics perfect:

  • Dialer
    • Call recording (BCR call recording app is one of the app that we can refer to but that requires root access to be existent)
    • Spam detection (One of the Simple dialer fork has it where you put up the API key of Truecaller account and you're good to go)
    • When you open dialer and click search, it should also recommend contacts from the contact list instead of showing nothing
    • Latest beta 4.8.3 crashes when clicked on loud speaker (You need to have Bluetooth turned on and device connected like a smart watch or an ear phone)
  • Gallery
    • MaterialYou Themed icon looks bad and is completely different from the actual icon (I'm not sure whether it is the default launcher doing it but yeah)
    • Built in video edit support
    • Optionally, GPhotos like advanced editing tools with MLKit (I've no idea on how hard it is to achieve but most of them work offline)
  • Files -- I've no idea whether this app is is being maintained or not (Material Files has these so refer the implementation)
    • Backup and Restore
    • Amoled black with MaterialYou
    • FTP
    • APK Achieve viewer
    • Option to add more storage options such as Cloud additions (Filen, GDrive, RClone, WebDav pCloud), USB, etc.,
    • More customisation option w.r.t folder designs and all those stuff

And finally, all these apps would work great if they've better integration to system like Google apps have (AFAIK, they interact with GMS to get their things done, but I run a different OS that does not have Google apps and yet they (Google clock, Maps, Dialer without GMS) work great ).

Keep Up With Fossify! (SMT Is Dead)

As of December 2023, the SimpleMobileTools apps get no updates anymore, because it was sold to a spyware and ad company. But for a couple of months now, there is this organization called Fossify, which forks all of the SMT apps and continue with new features / bug fixes.

It would be great to see that the Goodwy apps are still getting updates with all of the Fossify commits, so they are still the same app with new features / bug fixes. Maybe there is an option, where you can compare the changes to the Goodwy app version and the Fossify app version. But for now I can only see that you can compare it if you fork the project:

https://github.com/FossifyOrg/Gallery/compare

Here are some changes, they've made from their changelogs. I only added some of them, because it would have been too long and also added the links to the repos, so you can check for yourself:

  • Removed proprietary panorama library (halved APK size as a result).

  • Removed fake app message when using the editor.

  • Fixed zooming in high-res images

  • Added support for AVIF

  • Fixed position reset after device rotation

  • Fixed crash when playing videos

  • Added some translations

  • And more

  • https://github.com/FossifyOrg/Gallery

  • Folders now use primary/accent color.

  • Addressed unnecessary delays when renaming files.

  • Enhanced search performance in the text editor.

  • Fixed unresponsive behavior when viewing contents of a zip file.

  • Disabled the use of invalid characters such as / when batch renaming.

  • Fixed invisible sort menu when viewing storage summary.

  • Added some translations.

  • https://github.com/FossifyOrg/File-Manager

  • Removed call history limit

  • Added quick dial-back feature.

  • The hang-up button is now always visible in the call UI.

  • Enhanced the size of the caller avatar and buttons in the call UI

  • Reorganized dialpad preferences into their own dedicated section.

  • Added placeholder avatar for unknown numbers and contacts without photo.

  • Added a progress indicator to indicate (initial) call history retrieval.

  • Added bottom padding in lists to allow scrolling above the floating action button.

  • Fixed an issue where call history wasn't refreshing

  • Fixed a problem where search items would disappear

  • Fixed a UI freeze that happened when loading call history.

  • Fixed a bug that caused the search to not find older call logs

  • Fixed a crash that occurred when using the dialpad quick callback feature.

  • Restructured the in-call UI to be more responsive to different screen sizes and avoid overlapping views

  • New features and UI/UX Improvements

  • Moved some actions back into the popup menu to reduce visual clutter.

  • Missed call notifications are now automatically dismissed when you view your call history.

  • Disabled call action buttons after a call ends for better UI/UX.

  • Grouped call history entries by date.

  • Added an option to format phone numbers in the call log

  • Always show the date in the call details dialog.

  • Updated call direction icons and colors in the call history for better clarity.
    Updated menu design for better UI/UX.

  • Added some translations.

  • https://github.com/FossifyOrg/Phone

https://github.com/FossifyOrg/Messages

https://github.com/FossifyOrg/Contacts

https://github.com/FossifyOrg/Commons

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.