Giter Club home page Giter Club logo

Comments (4)

bketelsen avatar bketelsen commented on May 24, 2024 1

I have some thoughts here, I need to formalize, I think there's more to this.

from athens.

arschles avatar arschles commented on May 24, 2024

Continuing conversation on slack, @bketelsen you formalized all (we think) of the possible CLI workflows (copied to here). The question that remains is whether 2.i will cause vgo to hit the http://athensproxywhatever//githublcim/bketelsen/captainhook/@v/... endpoints directly, or still go through the ?go-get=1 flow.

If it's the former, this doesn't matter as much. Otherwise, we need this so the server knows where to redirect

from athens.

bketelsen avatar bketelsen commented on May 24, 2024

here's the code from vgo:

func (p *proxyRepo) Versions(prefix string) ([]string, error) {
	var data []byte
	err := web.Get(p.url+"/@v/list", web.ReadAllBody(&data))
	if err != nil {
		return nil, err
	}

zip, and other implementations are the same, they expect to call the proxy with the url.
also the proxy code has the concept of a base url and path:
gomods.io/proxy could be the "endpoint" for the proxy, which would result in a web request like:
https://gomods.io/proxy/github.com/bketelsen/captainhook/@v/list

from athens.

arschles avatar arschles commented on May 24, 2024

thanks @bketelsen - confirms my understanding too. reading the code cemented it too - good idea :)

the GoGet middleware still needs to be configurable for registry use, but not for proxy usage

from athens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.