Giter Club home page Giter Club logo

Comments (4)

r-ashish avatar r-ashish commented on June 21, 2024

I like the idea but this will also require a cache refresh otherwise we may have false positives while declaring a module version as complete.

from athens.

linzhp avatar linzhp commented on June 21, 2024

As long as the module/version is ever requested once, Athens will detect the absence of any of the 3 files and force cache refresh. So the only false positive would only happen to those newly cached modules/versions but never read since, which should be very rare. We can deploy the change in two stages to further reduce the chance:

Stage 1: enforce the order of saving the 3 files and have users to run go clean -modcache && go mod tidy to make sure that all active modules are complete
Stage 2: modify the Exits() function to check only the info file.

Alternatively, we can write an empty file instead, and use that as the atomic flag.

from athens.

manugupt1 avatar manugupt1 commented on June 21, 2024

Can we close this now @linzhp

from athens.

linzhp avatar linzhp commented on June 21, 2024

Yeah, with less calls to Exists() after #1842 and #1844 improving the performance, we don't need this anymore

from athens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.