Giter Club home page Giter Club logo

Comments (23)

andreszerocross avatar andreszerocross commented on June 24, 2024 1

Nice,, if someone like om Cecekpawon wes turun gunung. I think it will be easier to found the solution if both of Cecekpawon and GoldFish64 make a discussion :))

from audiopkg.

Goldfish64 avatar Goldfish64 commented on June 24, 2024

Possibly an issue with the callback in BootChimeDxe. Can you test again using all binaries compiled from this repo and not from Clover?

from audiopkg.

D-an-W avatar D-an-W commented on June 24, 2024

I had the same problem, it seems you can only have one or the other working at once.

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

Possibly an issue with the callback in BootChimeDxe. Can you test again using all binaries compiled from this repo and not from Clover?

Yes, it can go. But sound before GUI Theme of CLOVER is gone.

I check the log is about "No AudioIo found" if i use all AudioDxe.efi, BootChimeDxe.efi and BootChimeCfg.efi from your repo.

It's look i need to ask you to check Clover Code :D

i don't understand about C++

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

Update :

Use all your 2 binary (BootChimeCfg.efi, and AudioDxe.efi").

  1. I try reset NVRAM (F11 in CLOVER GUI)
  2. Boot into Mac, then reboot
  3. I can hear audio before CLOVER GUI (Strange, without need to set bootchimecfg.efi in shell first),, and not sound after press enter in macOS Partition (ofcourse, there is no BootChimeDxe.efi here)
  4. Get into desktop and put your BootChimeDxe.efi
  5. Reboot,, get audio before CLOVER GUI,, then i can hear audio when press enter in macOS partition but FREEZE (No loading bar / progress)

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

Update : I rebuild your AudioPkg 1 minute ago

Result :

  1. Audio From Clover is working
  2. Audio from BootChimeDxe Working too
  3. no Freeze.

Did you change file recently,, it's look you made change 17 hours ago. And my report before is from your repository 17 hours ago

from audiopkg.

Goldfish64 avatar Goldfish64 commented on June 24, 2024

I just tested on mine and with Clover's build of AudioDxe it does indeed freeze after playback of the startup sound.

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

I just tested on mine and with Clover's build of AudioDxe it does indeed freeze after playback of the startup sound.

Yes i experienced it before.

My step is

  1. Reset Nvram (F11 in clover)
  2. Boot into mac
  3. Use your AudioDxe.efi + bootchimecfg.efi latest from repo (i built it recently)
  4. Don't use BootChimeDxe.efi
  5. Reboot,, (no need to set nvram for Audio, but strange i can still hear sound before CLOVER GUI)
  6. in desktop, i put your BootChimeDxe.efi in drivers64UEFI.
  7. All working good (But same step is fail before, i don't understand)

i just put "Sound.wav and sound_night.wav" in my Theme Folder.

from audiopkg.

Goldfish64 avatar Goldfish64 commented on June 24, 2024

I'm assuming "sound before CLOVER GUI" refers to the startup sound that Clover makes when it loads? How is that configured? I am not up to speed with the various changes as I only found out recently that Clover had incorporated my driver.

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

I'm assuming "sound before CLOVER GUI" refers to the startup sound that Clover makes when it loads? How is that configured? I am not up to speed with the various changes as I only found out recently that Clover had incorporated my driver.

We just need to put "sound.wav" and "sound_night.wav" in theme folder name. Eg, my theme folder is "BGM_SVG" so i put both of wav files into it :D

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

Please check this : https://www.insanelymac.com/forum/topic/304530-clover-change-explanations/?do=findComment&comment=2657187

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

And this my video for the success, use all your binary. But i don't set bootchimecfg.efi yet. It's work normally without set it first. Is this normal????
https://youtu.be/WfaFOyFxf44

from audiopkg.

Goldfish64 avatar Goldfish64 commented on June 24, 2024

Yes BootChimeDxe will try to use a default device and max volume if the NVRAM variables do not exist.

from audiopkg.

cecekpawon avatar cecekpawon commented on June 24, 2024

Hello @andreszerocross sorry for hijacking your ticket here ;))

@Goldfish64 Thanks for your great driver! I have made a driver days ago to work with your AudioDxe which also experiencing boot freezes. Already share it on IM Ozmosis thread. For me, my StartPlaybackAsync callback will never get called. Something like unfinished progress (or broken timer?). Freeze on: "Block 3 of 8 filled! ..." on ExitBS.

For your new interactive BootChimeCfg, i got immediately "EFI_DEVICE_ERROR" msg on program start right after showing the menu. I comment out "WaitForEvent" return check as below as temporary workaround.

diff --git a/Application/BootChimeCfg/BootChimeCfg.c b/Application/BootChimeCfg/BootChimeCfg.c
index 0138cdf..8983c70 100644
--- a/Application/BootChimeCfg/BootChimeCfg.c
+++ b/Application/BootChimeCfg/BootChimeCfg.c
@@ -66,9 +66,9 @@ WaitForKey(
         return EFI_INVALID_PARAMETER;
 
     // Wait for key.
-    Status = gBS->WaitForEvent(1, &(SimpleTextIn->WaitForKey), &EventIndex);
-    if (EFI_ERROR(Status))
-        return EFI_DEVICE_ERROR;
+    /*Status =*/ gBS->WaitForEvent(1, &(SimpleTextIn->WaitForKey), &EventIndex);
+    //if (EFI_ERROR(Status))
+    //    return EFI_DEVICE_ERROR;
 
     // Get key value.
     Status = SimpleTextIn->ReadKeyStroke(SimpleTextIn, &InputKey);

Also found duplicate guid here.

🍻

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

But just for the information,, my sound is working now. Before and after GUI CLover is work perfectly.

  1. Use official release Clover r4842
  2. Use "sound.wav" and "sound_night.wav" ini themes folder
  3. Use 3 binary from GoldFish64 (BootchimeDxe.efi, BootChimeCfg.efi and AudioDxe.efi'

if you need another log or info, please ask me free. It's really amazing can hear sound before and after CLOVER GUI 👯‍♂️

from audiopkg.

Goldfish64 avatar Goldfish64 commented on June 24, 2024

@cecekpawon Did you compile AudioDxe.efi yourself? The same exact issue affects BootChimeDxe when used with AudioDxe from Clover: the callback is never called.

from audiopkg.

cecekpawon avatar cecekpawon commented on June 24, 2024

Yes @Goldfish64, compiled by my self. I dont use Clover + have not test any Clovers AudioPkg binaries, so I cant compare it for you, sorry. BootChimeDxe will resulting boot freeze + ExitBootServices error msg (I will take a photo for you later sir).

Quick looking into Clover sources, their StartPlaybackAsync callback is NULL >>>

Attached when it run with mine.

x

EDIT: Forgot to mentioned, due callback is never called, the sound keep looping until before reaching the desktop.

from audiopkg.

Goldfish64 avatar Goldfish64 commented on June 24, 2024

Sounds like something is interrupting the driver during playback. Does sync playback work fine?

If the driver doesn't refill the HDA controller's buffer with new data, the controller will continue to loop the same data over and over.

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

Just for update :
image

I set this to my config.plist.. if PlayAsync=Yes then audio will laggy in GUI CLOVER.
I don't know if this is useful information

from audiopkg.

cecekpawon avatar cecekpawon commented on June 24, 2024

Does sync playback work fine?

Yes it does.

Attached BootChimeDxe ExitBS error with Aptiofix2 and AMF.

  • What the strange is, its only happened on verbose boot on my machine. While @andreszerocross stuck on Apple logo without progress bar 🤣
  • Callback appear to be called on BootChimeDxe, while mine is (still) never. Already tried to override LoadImage and StartImage. Will keep trying ...

10 50 12
10 48 53

from audiopkg.

andreszerocross avatar andreszerocross commented on June 24, 2024

Does sync playback work fine?

Yes it does.

Attached BootChimeDxe ExitBS error with Aptiofix2 and AMF.

  • What the strange is, its only happened on verbose boot on my machine. While @andreszerocross stuck on Apple logo without progress bar 🤣
  • Callback appear to be called on BootChimeDxe, while mine is (still) never. Already tried to override LoadImage and StartImage. Will keep trying ...

10 50 12
10 48 53

But now, it's working without problem. Use AudioDxe.efi, BootChimeDxe.efi and BootChimecfg.efi from GoldFish64 Repository, Clover r4844, and sound.wav + sound_night.wav ini Theme folder

from audiopkg.

cecekpawon avatar cecekpawon commented on June 24, 2024

Argh @andreszerocross please close this issue then. I will reopen this issue If the problem still persist 🍻

from audiopkg.

cecekpawon avatar cecekpawon commented on June 24, 2024

I finally managed to make it work by overriding ExitBS like BootChimeDxe did. Is there any other way besides those to catch our callback?

Also, is it true ControllerInfo->GetVendorId (>>>) is not implemented yet? Accidentally calling those prop for debugging resulting boot hang.

Thanks.

from audiopkg.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.