goldengnu / java-dds Goto Github PK

What steps will reproduce the problem?
1.Create a thread that load a dds file 
2.Launch multiple threads loading different images

What is the expected output? What do you see instead?
Expected : fully loaded images
Instead:
<code>
Exception in thread "Thread-9" java.lang.ArrayIndexOutOfBoundsException: 4
    at net.nikr.dds.DDSLineReader.decodeDXT(DDSLineReader.java:182)
    at net.nikr.dds.DDSLineReader.decodeLine(DDSLineReader.java:86)
    at net.nikr.dds.DDSImageReader.read(DDSImageReader.java:280)
    at javax.imageio.ImageIO.read(ImageIO.java:1448)
    at javax.imageio.ImageIO.read(ImageIO.java:1308)
    at lol.reader.img.Image.get(Image.java:37)
    at lol.viewer.table.CellFactory$2$2.loadProcess(CellFactory.java:215)
    at lol.viewer.table.CellFactory$2$2.loadProcess(CellFactory.java:1)
    at lol.viewer.table.CellLoader$1.run(CellLoader.java:91)
    at java.lang.Thread.run(Thread.java:722)
Exception in thread "Thread-11" java.lang.ArrayIndexOutOfBoundsException: 4096
    at net.nikr.dds.DDSLineReader.decodeAtiAndDxt5AlphaBlock(DDSLineReader.java:330)
    at net.nikr.dds.DDSLineReader.decodeDXT(DDSLineReader.java:172)
    at net.nikr.dds.DDSLineReader.decodeLine(DDSLineReader.java:86)
    at net.nikr.dds.DDSImageReader.read(DDSImageReader.java:280)
    at javax.imageio.ImageIO.read(ImageIO.java:1448)
    at javax.imageio.ImageIO.read(ImageIO.java:1308)
    at lol.reader.img.Image.get(Image.java:37)
    at lol.viewer.table.CellFactory$2$2.loadProcess(CellFactory.java:215)
    at lol.viewer.table.CellFactory$2$2.loadProcess(CellFactory.java:1)
    at lol.viewer.table.CellLoader$1.run(CellLoader.java:91)
    at java.lang.Thread.run(Thread.java:722)
</code>

What version of the product are you using? On what operating system?
version used : HEAD on Win7 64

Please provide any additional information below.

The issue seems to be solved by changing variable declaration in DDSLineReader 
from:
<code language="java">
   private static byte[][][] linesColor;
   private static int lineNumber = 0;
</code>
to:
<code language="java">
   private byte[][][] linesColor;
   private int lineNumber = 0;
</code>

A feature request.

Please upload this artifact to Maven Central (or to another big maven repo)
Makes automatic dependency managment much easier for this package.


Explaination on how to do so
http://kirang89.github.io/blog/2013/01/20/uploading-your-jar-to-maven-central/

(referenced in the first link)
https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage
+Guide#SonatypeOSSMavenRepositoryUsageGuide-2.Signup

What steps will reproduce the problem?
1.Use case-sensitive file system
2.Try to build jar with maven

What is the expected output? What do you see instead?
All tests fail on a case-sensitive file system
with a file-not-found exception

What version of the product are you using? On what operating system?
Current version. An Ubuntu based distro.

Please provide any additional information below.
Solution:
The default file system is case-sensitive, in the code all all files have a 
lowercase extension (.dds), some of the test files have an uppercase extension. 
(.DDS)

(in src/test/resources/net/nikr/dds/)
For example ATI1N.DDS should be ATI1N.dds

Rename all .DDS files to .dds to solve this issue

The only other problem are the system-specific directory separators.
Windows uses a backslash, the rest a forward slash.
Use the constant "File.separator" for directory separators to avoid this 
problem:

in DDSImageReaderTest.java
...
private class TestParams{
  private final String pathSeparator = File.separator;
  private final String dir = "src" + pathSeparator + "test" + pathSeparator + "resources" + pathSeparator + "net" + pathSeparator + "nikr" + pathSeparator + "dds" + pathSeparator;
...

After those corrections the project compiled

What steps will reproduce the problem?
1. Have a class with a method that successfully loads a PNG file 
(ImageIO.read(URL/InputStream/etc)).
2. Add java-dds to classpath.
3. Attempt to execute the aforementioned method.

What is the expected output? What do you see instead?
Expected output: PNG is successfully read into an Image object.
Result: javax.imageio.IIOException: I/O error reading PNG header!
[...]
Caused by: javax.imageio.IIOException: Bad length for IHDR chunk!

What version of the product are you using? On what operating system?
SVN rev 16. Windows 7 Pro x86, Java 6u43 x86.

Please provide any additional information below.
I have attached a suggested fix for this issue.

The license text in your files states:

You should have received a copy of the GNU General Public License
along with Java DDS ImageIO Plugin; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

But no LICENSE file is included in the root of the repository.
Please add your license to your repo.

DXT5nm format is not read correct

What steps will reproduce the problem?
1.Use advanced code sample (see project front page) with attached image 
test.dds(contains no mipmaps)
2.imageReader.getNumImages returns 0, should be 1 (is this correct?)

What version of the product are you using? On what operating system?
current version, Win 7, Java 7

Please provide any additional information below.
test.dds and test2.dds are identical, the only difference is that
test.dds has no mipmaps while test2.dds has 8

test.dds contains no mipmaps: GetNumImages should return 1
(256x256)

test.dds contains mipmaps: GetNumImages returns 9 (correct)
(256x256) (128x128) (64x64)
(32x32) (16x16) (8x8)
(4x4) (2x2) (1x1)


If the return statement is modified the correct image is returned:
if (imageIndex <= max) return imageReader.read(imageIndex);
(this of course is wrong, count starts from 0)

Using ImageIO.read directly works.