gogoout / nativescript-rater Goto Github PK

View Code? Open in Web Editor NEW

7.0 7.0 8.0 2.13 MB

Reminds your app's users to review the app through PlayStore or AppStore. Love it, rate it! **not maintained anymore**

License: MIT License

Shell 13.75% Ruby 0.33% TypeScript 77.27% JavaScript 8.64%

nativescript-rater's People

Contributors

Stargazers

Watchers

Forkers

shiv19 osmanertem bbroerees igorkra sergeymarkovmobidev diegomacbd adrianpdaluz

nativescript-rater's Issues

Android: Dialog not working with usesUntilPrompt

main.ts
import {appRater} from 'nativescript-rater';
appRater.init();

app.component.ts
import {appRater} from 'nativescript-rater';
-- onInit
appRater
        .setDaysUntilPrompt(7)
        .setUsesUntilPrompt(3)
        .setSignificantUsesUntilPrompt(2)
        .setShowLaterButton(true)
        .setShowNeverButton(true)
        .setDebugMode(true);
appRater.showRateDialogIfMeetsConditions();

UntilPrompt not working, I tried to launch the app 4 times but the dialog not show.

IOS star rating prompt not showing

Hi, on IOS after you select "rate demo" on the initial pop up nothing happens.
Ive checks on IOS emulators and device using the demo app supplied as well as my own angular app.

Im using IOS version 13.3
nativescript - 6.5.0

Thanks

Android API Level 17 Error

Error while building android on api lever 17

/Users/bellalmohamed/Development/zeal-area/Zeal-Members-App-Native/platforms/android/app/src/main/AndroidManifest.xml Error:
        uses-sdk:minSdkVersion 17 cannot be smaller than version 21 declared in library [:nativescript-rater:] /Users/bellalmohamed/.gradle/caches/transforms-2/files-2.1/cb8dc1ca29e8e5d1b47ded14a870aa9d/nativescript-rater/AndroidManifest.xml as the library might be using APIs not available in 17
        Suggestion: use a compatible library with a minSdk of at most 17,
                or increase this project's minSdk version to at least 21,
                or use tools:overrideLibrary="hotchemi.android.rate" to force usage (may lead to runtime failures)

In-App Review support

This is actually not an issue.

Will you support the new In-App Review system by Android ? Here's the link.

Android side is not working with {N} 6

JS: NativeScript discardedErrorEvent:  Error: Calling js method onSingleTapUp failed
JS: Error: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.app.Activity.isFinishing()' on a null object reference
JS:     hotchemi.android.rate.AppRate.showRateDialog(AppRate.java:184)
JS:     com.tns.Runtime.callJSMethodNative(Native Method)
JS:     com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1242)
JS:     com.tns.Runtime.callJSMethodImpl(Runtime.java:1122)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1109)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1089)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1081)
JS:     android.view.GestureDetector_SimpleOnGestureListener_vendor_114937_32_TapAndDoubleTapGestureListenerImpl.onSingleTapUp(Unknown Source:20)
JS:     android.view.GestureDetector.onTouchEvent(GestureDetector.java:641)
JS:     androidx.core.view.GestureDetectorCompat$GestureDetectorCompatImplJellybeanMr2.onTouchEvent(GestureDetectorCompat.java:480)
JS:     androidx.core.view.GestureDetectorCompat.onTouchEvent(GestureDetectorCompat.java:543)
JS:     com.tns.Runtime.callJSMethodNative(Native Method)
JS:     com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1242)
JS:     com.tns.Runtime.callJSMethodImpl(Runtime.java:1122)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1109)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1089)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1081)
JS:     java.lang.Object_vendor_109889_32_TouchListenerImpl.onTouch(Unknown Source:13)
JS:     android.view.View.dispatchTouchEvent(View.java:12589)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3028)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2705)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     an...
JS: NativeScript discardedErrorEvent:  Error: Calling js method onTouch failed
JS: Error: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
JS:     android.view.GestureDetector_SimpleOnGestureListener_vendor_114937_32_TapAndDoubleTapGestureListenerImpl.onSingleTapUp(Unknown Source:26)
JS:     android.view.GestureDetector.onTouchEvent(GestureDetector.java:641)
JS:     androidx.core.view.GestureDetectorCompat$GestureDetectorCompatImplJellybeanMr2.onTouchEvent(GestureDetectorCompat.java:480)
JS:     androidx.core.view.GestureDetectorCompat.onTouchEvent(GestureDetectorCompat.java:543)
JS:     com.tns.Runtime.callJSMethodNative(Native Method)
JS:     com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1242)
JS:     com.tns.Runtime.callJSMethodImpl(Runtime.java:1122)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1109)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1089)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:1081)
JS:     java.lang.Object_vendor_109889_32_TouchListenerImpl.onTouch(Unknown Source:13)
JS:     android.view.View.dispatchTouchEvent(View.java:12589)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3028)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2705)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3034)
JS:     android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719)
JS:     android.view.ViewGroup.dispatchTransformedTouchEvent...

ReferenceError: Can't find variable: SwiftRater

I'm getting the above error after adding the plugin (via NS Sidekick) and then importing it in main.ts, and calling appRater.init(.... just before the boostrapping:

import { platformNativeScriptDynamic } from "nativescript-angular/platform";

import { AppModule } from "./app/app.module";
import { appRater } from 'nativescript-rater';

appRater.init({
    showNeverButton:false,
    debugMode:true
});
platformNativeScriptDynamic().bootstrapModule(AppModule);

DebugMode False, keeps showing review request every time.

Make sure to check the demo app(s) for sample usage

Demo runs without problem

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital
letter.

Which platform(s) does your issue occur on?

iOS/Android/Both
iOS/Android versions
emulator or device. What type of device?

I used both Android and IOS, emulator and real devices as well.

Please, provide the following version numbers that your issue occurs with:

tns version 6.1.2
  "tns-android": {
  "version": "6.1.2"
},
"tns-ios": {
  "version": "6.1.1"
   }
  },
  "description": "NativeScript Application",
  "license": "SEE LICENSE IN <your-license-filename>",
  "repository": "<fill-your-repository-here>",
  "dependencies": {
    "nativescript-admob": "^4.0.0",
    "nativescript-audio-player": "^1.0.3",
    "nativescript-gif": "^4.0.2",
    "nativescript-image": "^2.2.5",
    "nativescript-local-notifications": "^4.0.1",
    "nativescript-rater": "^2.1.1",
    "nativescript-theme-core": "~1.0.6",
    "tns-core-modules": "~6.1.0"
  },
  "devDependencies": {
    "nativescript-dev-webpack": "~1.2.0"

Please, tell us how to recreate the issue in as much detail as possible.

Describe the steps to reproduce it.

Demo runs without a problem and I integrated it to my app. As it is mentioned in the README. I get the review request every time pages loads. ( I trigger the appRater.showRateDialog() on page load.)

I wanted to test the plugin by setting the debug mode to false. So I would check usesUntilPrompt (3) works or not. I was expecting that when the pages load I would not see review request until I launched the app 4th times. But whenever the pages loads review request page appears. Having this in released version would be a problem.

So, will I have the similar issue with the released version? Or is there a way to test configs?

Thank you in advance.

Is there any code involved?

provide a code example to recreate the problem
(EVEN BETTER) provide a .zip with application or refer to a repository with application where the problem is reproducible.

NativeScript 8 support

Android error while build with plugin installed: Could not find method compile() for arguments [com.github.hotchemi:android-rate:1.0.1] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

iOS error while plugin use: ERROR in ./node_modules/nativescript-rater/rater.ios.js 4:14-50
Module not found: Error: Can't resolve 'tns-core-modules/ui/frame' in './node_modules/nativescript-rater'
resolve 'tns-core-modules/ui/frame' in './node_modules/nativescript-rater'

NativeScript 8.2.3
@nativescript/android 8.2.2
@nativescript/ios 8.2.2
node v17.6.0
npm 8.1.4

adding plugin to android platform make it impossible to run or build. To reproduce in android just call

tns plugin add nativescript-rater
tns prepare android
tns run android
adding plugin to ios runs and builds fine until plugin init in app code. . To reproduce in is call
tns plugin add nativescript-rater
add import { appRater } from 'nativescript-rater';
and appRater.init({
showNeverButton:false,
debugMode: false,
significantUsesUntilPrompt: 0,
daysBeforeReminding: 0,
daysUntilPrompt: 14,
// showLaterButton: true
// debugMode: !TARGET_ENVIRONMENT_CONFIG.production
});
tns prepare ios
tns run ios

Feature on iOS - Add app country code parameter due to iTunes lookup fail.

Hello,

There is an issue on iOS when the app is available in only one country. The iTunes lookup return an empty response.

Related issue : takecian/SwiftRater#30

SwiftRater documentation :
SwiftRater.countryCode = "fr"

Could you please add this parameter in the next version of this NS plugin ? Thank you.

Unexpected behaviour on showRateDialog()

Hi, when calling showRateDialog() on IOS 13.3 i am am being prompted by the dialog used for 〜 iOS 10.2 not the star rating dialog for iOS 10.3 〜.

When i set debug to true as shown below, then call showRateDialogIfMeetsConditions() the star rating dialog shows as expected.

appRater.init({
showNeverButton: false,
debugMode: true
});

I would expect showRateDialog() to prompt the star rating dialog ?

Thanks

Android string xml resources

I can't figure out where to put the custom labels for Android.

Can someone give me the path and the filename?

topmost() is deprecated. Use Frame.topmost() instead

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital
letter.

Which platform(s) does your issue occur on?

iOS/Android/Both -> iOS
iOS/Android versions -> All
emulator or device. What type of device? -> All

Please, provide the following version numbers that your issue occurs with:

CLI: (run tns --version to fetch it) -> All
Cross-platform modules: (check the 'version' attribute in the
node_modules/tns-core-modules/package.json file in your project)-> 6.5.1
Runtime(s): (look for the "tns-android" and "tns-ios" properties in the package.json file of your project) -> 6.5.0
Plugin(s): (look for the version numbers in the package.json file of your
project and paste your dependencies and devDependencies here) -> none

Please, tell us how to recreate the issue in as much detail as possible.

Describe the steps to reproduce it.

add rater plugin
start iOS simulator
open rater -> a console warning appears

Is there any code involved?

provide a code example to recreate the problem
(EVEN BETTER) provide a .zip with application or refer to a repository with application where the problem is reproducible.

A pull request is coming any minute now :)

gogoout / nativescript-rater Goto Github PK

nativescript-rater's People

Contributors

Stargazers

Watchers

Forkers

nativescript-rater's Issues

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

Is there any code involved?

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

Is there any code involved?

Recommend Projects

Recommend Topics

Recommend Org