Comments (4)
goetzrobin
commented on May 24, 2024
1
Thanks for all your efforts and catching that! This should be run as part of the lintstaged hook as defined the .lintstagedrc file.
Seems like some slipped through the cracks... we can run prettier on all and see if the issue pops up again.
from spartan.
ajitzero
commented on May 24, 2024
1
I think we can close this one since newer PRs will always go through commit lint & prettier in the CI process. The commit hook also seems to be in place so the issues we saw earlier were probably before prettier was added to the CI action.
from spartan.
ajitzero
commented on May 24, 2024
@goetzrobin I can look into setting this up over this weekend if this sounds reasonable. Please let me know your thoughts on this.
from spartan.
ajitzero
commented on May 24, 2024
Should I run prettier in my existing PR then? Even if it modifies files outside my scope of changes? The CI flagged my PR correctly to not have formatting done.
from spartan.
Related Issues (20)
- The select control become dirty on multiple mode with initlal value or patch value HOT 9
- Feature - making the image in The 300 clickable along with the text HOT 6
- Feature Request: "Select All" Option for Spartan-NG Select Control HOT 6
- not able to generate code (either using angular api or nx) for sonner HOT 4
- select: initial value is not set when number, initial value of multiple is erased if additional values are selected
- Include authentication UI example at examples page HOT 2
- Docs mention @ngneat/cmdk instead of @ngxpert/cmdk HOT 1
- RFC: Advanced pagination
- RFC: Radio Groups as card layouts HOT 6
- Docs: API reference for all components
- Renaming the generated `hlm-` selector to anything else breaks the `select` component HOT 10
- Popover overflowing past screen when trigger is on the edge of the screen HOT 3
- Add the multi select component
- Peer dependencies causing problem - multiple versions of ui-core HOT 3
- ERROR RuntimeError: NG0203: inject() must be called from an injection context such as a constructor
- ERROR ReferenceError: window is not defined HOT 1
- [nitro] [request error] [unhandled] [GET] "/trpc/note.list,note.list
- Error: Error: Cannot find module tslib ... code: 'ERR_MODULE_NOT_FOUND'
- (node:77788) [DEP0155] DeprecationWarning: Use of deprecated trailing slash pattern
- Dropdown does not lock page scroll HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.