Comments (9)
I think I'll have some time tonight to look into this. Assigning this issue to myself
from spartan.
I did not take directly but wanted to keep all the tests using the testing-library, but I think I captured same scenarios and plus some. I will say looking at the tests alex put together again maybe oddly the changes are not are getting picked up at each step. I didn't force the detect changes like he did, but let me try that and see if I get a different result.
from spartan.
@wizardnet972 - just wanted to confirm, will you be opening a PR for this issue? Otherwise I can take a look, let me know.
from spartan.
So I took the liberty to write some unit tests for the brn-select
component, before taking a look at the list of issues again, and I found the same bug when writing a test case for initializing it with a default value.
I don't have time to find the underlying issue, but I can at least share the code for the unit tests that I wrote so at least that isn't time wasted. https://pastecode.io/s/xs76uc19
from spartan.
@wizardnet972 any plans on tackling this soon? this is the last bug that prevents me from starting to use the select component instead of the native one
from spartan.
I apologize I have been ill for the past week or so and then had to catch up on alot of work so I didnt get a chance to open this till now. I added quite a few more tests for select to try and find the issue but I don't think I'm able to replicate the issue in the tests. From what I can tell the form statuses seem to be correct unless I'm missing something. Maybe someone can double check me #278
from spartan.
So I took the liberty to write some unit tests for the
brn-select
component, before taking a look at the list of issues again, and I found the same bug when writing a test case for initializing it with a default value.I don't have time to find the underlying issue, but I can at least share the code for the unit tests that I wrote so at least that isn't time wasted. https://pastecode.io/s/xs76uc19
@thatsamsonkid were you able to incorporate these tests also?
from spartan.
Sounds good. And I do prefer testing library also. I am wondering if there's some CD issues
from spartan.
Wanted to just give a small update. I did resolve the issue with the tests not showing this and also now finally found what was causing the issue for this finally. I've just been short on time but hoping will be pushing a PR fix for this in next few days. Apologies it took this long and hopefully we should have a good number of tests to cover these things now
from spartan.
Related Issues (20)
- Where would you like to create your workspace - question missing from Installation guide HOT 3
- Checkboxes within a scrollarea
- Tooltip covers other Elements after hiding
- using aria-describedby is causing a blank line at the end of the page
- NG0311: Directive CdkMenuTrigger does not have an input with a public name of brnMenuTriggerFor. HOT 4
- Error: No matching export for "DynamicViewModule" in @ngneat/overview package HOT 2
- Data Table: Table height does't update when size options change
- Wrong Import typography-helm DOCS
- [Avatar] Dont Show Avatar after fetching user Data HOT 16
- [Feature Request] - namespace css variables please HOT 2
- [Feature Request] - Add components to under one lib or to an existing lib HOT 1
- Bartender not working HOT 2
- Dynamic table columns HOT 1
- Blocked aria-hidden
- RFC: Additional options for Dialog component
- Select dependencies not installed with CLI HOT 2
- Form Field CLI command not correct in docs HOT 5
- Should add the information about '@angular/cdk/overlay-prebuilt.css' to any components that use ? HOT 1
- Memorize libs directory HOT 2
- RFC: Ripple on Buttons HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.