Comments (9)
I think I'll have some time tonight to look into this. Assigning this issue to myself
from spartan.
I did not take directly but wanted to keep all the tests using the testing-library, but I think I captured same scenarios and plus some. I will say looking at the tests alex put together again maybe oddly the changes are not are getting picked up at each step. I didn't force the detect changes like he did, but let me try that and see if I get a different result.
from spartan.
@wizardnet972 - just wanted to confirm, will you be opening a PR for this issue? Otherwise I can take a look, let me know.
from spartan.
So I took the liberty to write some unit tests for the brn-select
component, before taking a look at the list of issues again, and I found the same bug when writing a test case for initializing it with a default value.
I don't have time to find the underlying issue, but I can at least share the code for the unit tests that I wrote so at least that isn't time wasted. https://pastecode.io/s/xs76uc19
from spartan.
@wizardnet972 any plans on tackling this soon? this is the last bug that prevents me from starting to use the select component instead of the native one
from spartan.
I apologize I have been ill for the past week or so and then had to catch up on alot of work so I didnt get a chance to open this till now. I added quite a few more tests for select to try and find the issue but I don't think I'm able to replicate the issue in the tests. From what I can tell the form statuses seem to be correct unless I'm missing something. Maybe someone can double check me #278
from spartan.
So I took the liberty to write some unit tests for the
brn-select
component, before taking a look at the list of issues again, and I found the same bug when writing a test case for initializing it with a default value.I don't have time to find the underlying issue, but I can at least share the code for the unit tests that I wrote so at least that isn't time wasted. https://pastecode.io/s/xs76uc19
@thatsamsonkid were you able to incorporate these tests also?
from spartan.
Sounds good. And I do prefer testing library also. I am wondering if there's some CD issues
from spartan.
Wanted to just give a small update. I did resolve the issue with the tests not showing this and also now finally found what was causing the issue for this finally. I've just been short on time but hoping will be pushing a PR fix for this in next few days. Apologies it took this long and hopefully we should have a good number of tests to cover these things now
from spartan.
Related Issues (20)
- Include authentication UI example at examples page HOT 2
- Docs mention @ngneat/cmdk instead of @ngxpert/cmdk HOT 1
- RFC: Advanced pagination
- RFC: Radio Groups as card layouts HOT 9
- Docs: API reference for all components
- Renaming the generated `hlm-` selector to anything else breaks the `select` component HOT 10
- Popover overflowing past screen when trigger is on the edge of the screen HOT 3
- Add the multi select component
- Peer dependencies causing problem - multiple versions of ui-core HOT 3
- ERROR RuntimeError: NG0203: inject() must be called from an injection context such as a constructor
- ERROR ReferenceError: window is not defined HOT 1
- [nitro] [request error] [unhandled] [GET] "/trpc/note.list,note.list
- Error: Error: Cannot find module tslib ... code: 'ERR_MODULE_NOT_FOUND'
- (node:77788) [DEP0155] DeprecationWarning: Use of deprecated trailing slash pattern
- Dropdown does not lock page scroll HOT 6
- Select: Initial Value is not set when options are provided vie @for
- Adding the hlmMenuItem directive on dropdown separated in multiple components throw an exception HOT 1
- unable to install nx-workspace with presets HOT 2
- hlmSelect does not have an invalid state style HOT 9
- Module Not recognize HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.