Comments (4)
Hi @ajitzero
I understand your point, but this issue is because I am trying to replicate the code that is in the documentation, in the documentation the combobox closes when I select an option.
I'm not sure if in the first version the combobox will support multiple options, we would have to see how shadcn has it, if it has a special component for multiselect or if a combobox is used.
I like your idea, thanks for commenting.
from spartan.
This will be part of the next release!
from spartan.
The current behavior is expected behaviour for a combobox, especially when selecting multiple items or searching for something and hitting "enter", we don't want it to be closed.
Your point makes sense in a single-select scenario and would be good to have as a directive/attribute here, like [comboboxSettings]="{ single: true }"
or [closeOnSelect]
- That way we don't need to track emitted event to do anything manually, and the actual emission (if needed), can be taken from the FormControl's valueChanges stream (or with ngModelChanges, take your pick).
What do you think?
from spartan.
Issue was addressed as part of releases: cli 0.0.1-alpha.334 & ui 0.0.1-alpha.321
from spartan.
Related Issues (20)
- @ngneat/cmdk is now ngxpert/cmdk
- SSR error on select component 'window' not found HOT 6
- Displaying the Icon component - adding route and view to spartan-side-nav-links HOT 8
- Adding icon as a choice in issue and PR templates
- RFC: Components overview HOT 7
- Why isn't the initial value applied to the select component after cloning the repo and running Storybook? HOT 3
- Easier usage of tooltip HOT 7
- Add the ability to group buttons HOT 1
- The select control become dirty on multiple mode with initlal value or patch value HOT 9
- Feature - making the image in The 300 clickable along with the text HOT 6
- Feature Request: "Select All" Option for Spartan-NG Select Control HOT 6
- not able to generate code (either using angular api or nx) for sonner HOT 4
- select: initial value is not set when number, initial value of multiple is erased if additional values are selected
- Include authentication UI example at examples page HOT 2
- Docs mention @ngneat/cmdk instead of @ngxpert/cmdk HOT 1
- RFC: Advanced pagination
- RFC: Radio Groups as card layouts HOT 6
- Docs: API reference for all components
- Renaming the generated `hlm-` selector to anything else breaks the `select` component HOT 10
- Popover overflowing past screen when trigger is on the edge of the screen HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.