Tested versions Reproducible in: Godot Engine v4.3.beta1.off

ReflectionProbe Reflection Masks have no effect on Mobile renderer about godot HOT 1 OPEN

RaineVixen commented on July 3, 2024 1

ReflectionProbe Reflection Masks have no effect on Mobile renderer

from godot.

Comments (1)

Calinou commented on July 3, 2024 2

I can confirm this when running the project with the Mobile rendering method, both on 4.2.2 and 4.3.beta 71699e0 (Linux, GeForce RTX 4090 with NVIDIA 550.78).

I also checked 4.1.2 and 4.0 and the issue is still present on those versions.

The code that handles reflection probe cull masks is here in Forward+:

godot/servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl

Lines 1670 to 1685 in 71699e0

 while (merged_mask != 0) { 

 uint bit = findMSB(merged_mask); 

 merged_mask &= ~(1u << bit); 

 #ifdef USE_SUBGROUPS 

 if (((1u << bit) & mask) == 0) { //do not process if not originally here 

 continue; 

 } 

 #endif 

 uint reflection_index = 32 * i + bit; 

 if (!bool(reflections.data[reflection_index].mask & instances.data[instance_index].layer_mask)) { 

 continue; //not masked 

 } 

 reflection_process(reflection_index, vertex, ref_vec, normal, roughness, ambient_light, specular_light, ambient_accum, reflection_accum); 

 }

And for Mobile:

godot/servers/rendering/renderer_rd/shaders/forward_mobile/scene_forward_mobile.glsl

Lines 1248 to 1261 in 71699e0

 for (uint i = 0; i < 8; i++) { 

 uint reflection_index = reflection_indices & 0xFF; 

 if (i == 3) { 

 reflection_indices = instances.data[draw_call.instance_index].reflection_probes.y; 

 } else { 

 reflection_indices = reflection_indices >> 8; 

 } 

 if (reflection_index == 0xFF) { 

 break; 

 } 

 reflection_process(reflection_index, vertex, ref_vec, bent_normal, roughness, ambient_light, specular_light, ambient_accum, reflection_accum); 

 }

from godot.

ReflectionProbe Reflection Masks have no effect on Mobile renderer about godot HOT 1 OPEN

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	while (merged_mask != 0) {
	uint bit = findMSB(merged_mask);
	merged_mask &= ~(1u << bit);
	#ifdef USE_SUBGROUPS
	if (((1u << bit) & mask) == 0) { //do not process if not originally here
	continue;
	}
	#endif
	uint reflection_index = 32 * i + bit;

	if (!bool(reflections.data[reflection_index].mask & instances.data[instance_index].layer_mask)) {
	continue; //not masked
	}

	reflection_process(reflection_index, vertex, ref_vec, normal, roughness, ambient_light, specular_light, ambient_accum, reflection_accum);
	}

	for (uint i = 0; i < 8; i++) {
	uint reflection_index = reflection_indices & 0xFF;
	if (i == 3) {
	reflection_indices = instances.data[draw_call.instance_index].reflection_probes.y;
	} else {
	reflection_indices = reflection_indices >> 8;
	}

	if (reflection_index == 0xFF) {
	break;
	}

	reflection_process(reflection_index, vertex, ref_vec, bent_normal, roughness, ambient_light, specular_light, ambient_accum, reflection_accum);
	}