Giter Club home page Giter Club logo

Comments (2)

RedMser avatar RedMser commented on May 27, 2024

When breakpointing into ResourceLoader::_load, you can see that the loader is missing.

TranslationServer::load_translations is called too early in the startup procedure. This fixes it for GDExtension, but I'm not sure if this possibly breaks anything:

diff --git a/main/main.cpp b/main/main.cpp
index eee634086e..1045c7b45f 100644
--- a/main/main.cpp
+++ b/main/main.cpp
@@ -2964,8 +2964,6 @@ Error Main::setup2() {
                if (!locale.is_empty()) {
                        translation_server->set_locale(locale);
                }
-               translation_server->load_translations();
-               ResourceLoader::load_translation_remaps(); //load remaps for resources
 
                ResourceLoader::load_path_remaps();
 
@@ -3064,6 +3062,9 @@ Error Main::setup2() {
 
        OS::get_singleton()->benchmark_end_measure("Startup", "Scene");
 
+       translation_server->load_translations();
+       ResourceLoader::load_translation_remaps(); //load remaps for resources
+
 #ifdef TOOLS_ENABLED
        ClassDB::set_current_api(ClassDB::API_EDITOR);
        register_editor_types();

GDScript relies on ResourceLoader::add_custom_loaders() which is called in Main::start()

from godot.

RedMser avatar RedMser commented on May 27, 2024

My linked PR only solves the issue for GDExtension, so I uploaded another MRP which showcases specifically this. I kept my DLL in there for convenience, but you may also build it from source if you do not trust random binaries off the internet.

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.