gobuffalo / here Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
Hi,
The release
target in the Makefile is looking for a command named release
. I tried googling it and couldn't find it anywhere.
Thanks
Tom
Go 1.18 introduced workspaces (https://go.dev/doc/tutorial/workspaces) defined by a go.work file defined in the parent directory of a module - these are useful for working with private packages, etc.
I have a setup where my buffalo project depends on a private "common" module for my organisation, and therefore I develop within a go workspace using the following directory structure:
matt@argon:~/ws$ ls common go.work web
Where web
contains my buffalo project, common
is the private module, and go.work
defined the go workspace.
Unfortunately attempting to use many buffalo-cli commands within this workspace fails with the following error:
matt@argon:~/ws/web$ buffalo task list Usage: buffalo task [flags] Aliases: task, t, tasks Flags: -h, --help help for task ERRO[0000] Error: here.Dir: /home/matt/ws/web: here.cache: /home/matt//ws/web: here.nonGoDir: /home/matt//ws/web: invalid character '{' after top-level value
The issue appears to be that the here module is unable to handle the JSON returned by go list when executed under a workspace, specifically the output of go list -json -m
(called by https://github.com/gobuffalo/here/blob/main/dir.go#L71) returns multiple JSON objects (not in a JSON array!), which then raises the error above when the output is parsed to json.Unmarshal on the following lines...
Example go list output:
matt@argon:~/ws/web$ go list -json -m { "Path": "github.com/MYORG/common", "Main": true, "Dir": "/home/matt//ws/common", "GoMod": "/home/matt//ws/common/go.mod", "GoVersion": "1.18" } { "Path": "github.com/MYORG/web", "Main": true, "Dir": "/home/matt/ws/web", "GoMod": "/home/matt/ws/web/go.mod", "GoVersion": "1.18" }
While arguably this is a go list
bug for returning multiple JSON objects outside of a JSON array, the fact that there's a released version of go doing this, to me means that this output format needs to be supported by the here command.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.