Giter Club home page Giter Club logo

creevey's People

Contributors

gobbledegook avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

creevey's Issues

Enhancement Request: Zoom keyboard

Recent convert to Phoenix from Abacus Industries Image Viewer, and I'm so impressed! The only thing that I'm missing in switching is the ability to zoom without leaving the arrow key area.

In "Image Viewer", Zoom In, Out, Full-Screen/Window were also given as Menu Items so that shortcuts could be assigned to them via MacOS keyboard configuration. That could be one option which would work for me without needing to rewrite all the docs/localization help, etc.

The other possibility would be to add , and . as alternates for zoom out/in. On US keyboards these are very close to the arrow keys and have < and > on the same keycap so like - and + they're intuitive. SlideshowWindow.m lines 984-996 are the only non-docs place that would need to be changed.

Rationale

I work with folders of high-res medieval manuscripts and I'm often searching for a particular word or passage, so my workflow is a lot of next/prev image, scroll with mouse, zoom in/out. So it's nice to have all these keyboard commands near the arrow (and w/o needing shift for +)

Again, my huge gratitude to you for making this software -- once Abacus's Image Viewer stopped navigating in iCloud directories, I was looking everywhere for something to replace it's speed and ease of use. You have surpassed in all respects!

Feature Request: Enforce Dark Mode in settings

This is only a nice to have and no bug.

I use my Mac mainly in "light" mode. But I like "dark" mode for certain apps.

Many apps allow to enforce "dark" mode in settings and especially my photo related apps (Photoshop etc.) are all on the darker side.

Feature request

  • Add an option in settings to let Phoenix Slides running it in dark mode always.
  • (Optional) Make the option a choice between: light mode (enforced), dark mode (enforced), system settings

Request: Fill image to width of screen

Loving Phoenix Slides!

One thing to make it even better would be the option to make the images fill the full width of the screen (and then overflow horizontally). It would fit neatly as a feature alongside Fit horizontally and Original size.

Hidden volume prevents files from being opened

If I mount a hidden volume in 10.9.4, it does not show up in Phoenix Slides, nor will any file on the volume open in Phoenix Slides. Any attempt to open an image on a hidden volume opens the Phoenix Slides app, emits a beep and then nothing else happens.

mahler:~ mlei$ GetFileInfo /Volumes/users-schubert/
directory: "/Volumes/users-schubert"
attributes: aVbstclinmedz
created: 03/10/2009 07:02:34
modified: 04/17/2014 08:12:39

mahler:~ mlei$ mount
/dev/disk0s2 on / (hfs, local, journaled)
devfs on /dev (devfs, local, nobrowse)
map -hosts on /net (autofs, nosuid, automounted, nobrowse)
map auto_home on /home (autofs, automounted, nobrowse)
//mlei@schubert._smb._tcp.local/users-schubert on /Volumes/users-schubert (smbfs, nodev, nosuid, mounted by mlei)

screen shot 2014-07-24 at 6 36 07 pm

EDIT: originally, I thought SMB was the issue, but it turns out that if the file is hidden, you won't be able to open anything under it.

Request: Ability/button to hide the folder browser

Sometimes I just want to drag a folder to the Phoenix Slides icon and jump through the images quickly. For that, I don't need the awesome folder browser at the top of the screen. Would be very nifty if I could hide it!

Lossless Crop of JPEG Files

the jpegtran library used by Phoenix Slides should support Lossless Crop
but there is apparently no Mac-Program, that has an GUI for Lossless Crop.

Lossless Crop could be an Unique and outstanding feature for Phoenix Slides.

so if you want to add features to Phoenix Slides please consider Lossless Crop as an option.

Regression: Application switches desktops when activating slideshow

I observed this started in v1.5.3, and I still see it on v1.5.4. The steps I use to reproduce:

  1. Have multiple Spaces (or desktops, or whatever Apple calls it now) created. I'll refer to two of them as desktop A and desktop B
  2. Start Phoenix Slides from desktop A
  3. Create an additional Phoenix Slides image browser window
  4. Navigate to some image folders on both image browser windows
  5. Move one of the image browser windows to desktop B
  6. Enter slideshow on the desktop A image browser window
  7. Exit slideshow
  8. Switch to desktop B and its image browser window
  9. Enter slideshow on the desktop B image browser window. You should observe here the horizontal desktop change animation
  10. Exit that slideshow. You should observe here that you're back in desktop A, but your two image browser windows should be still one on A and the other on B.

Expected behavior, observed in older versions (I think 1.5.2):

  1. No animation on step 9
  2. You're still on desktop B when you exit the slideshow on step 10

Environment: MacOS Sonoma 14.1.1, ARM64

option to start without slideshow (even though autoadvance is on)

Severely need an option to avoid start slideshow at startup, even though autoadvance is on!

When doubleclicking a jpg to start phoenix slides, it goes into slideshow at once, moving away from the photo i want to see, very confusing and sometimes embarrassing (especially if i present a photo which happen to be in the downloads folder... often have had to excuse and navigate back to the right photo)

As i often use autoadvancing slideshows, this setting is remembered upon closing phoenix, and next time i open a photo i will get the same autoadvancing at once, i have set jpg default to phoenix and always want to study selected photos by doubleclicking, it is amazingly fast and useful for this

There is a nice green button to start slideshow, so i see little point in having it start when the program launches, however to keep other users workflow it would be safest to add an option in the slideshow preferences whether to have the slideshow start at program launch (default toggled on)

Feature Request: Filtering option

I have been using phoenix slides for many years, and thanks for great app you have created.
One feature which I find useful (based on other app) but missing from phoenix slides is doing basic filtering of photo listing, eg. having a filter text box to key in regex and filter photos list based on filename. eg. I have hundreds of phots in a folder, but I just want to show the photos file name matching "2001-*".
I believe this can be implemented as the app already has a function to scan the folder and search for photo files.
Hope this can be implemented. Thanks a lot in advance.

Timeline strip option

Hi,

I LOVE Phoenix Slides. My use case is sorting a lot of photos I take of my son. I shoot hundreds, and then move through them deleting a lot and keeping the best. This often requires flipping back and forwards between several very similar shots.

With 10.6.8 I used Preview, and it worked fine. I would use the left-hand vertical film strip preview to see where I was in my collection, especially with regard to similar photos.

However, under 10.9 Preview is far too slow to update the main photo when moving up and down in the film strip. At one patch level (10.9.3 I think), this seemed to massively improve. Under 10.9.4 it's super slow again. Eg, move up several photos in the film strip then stop. It takes a good second or to display the full image. This is just too slow to do the quick back-and-forwards that I use to decide on a one photo out of a similar set to keep.

So I found Phoenix Slides. It is faster than Preview under 10.6.8, so thank you! The only thing I miss if the film strip like preview to give me a visual indicator as to where I am in my collection and with regards to similar sets of photos.

Is there any chance such a feature could find it's way in to a future release?

Wrong Picture Rotation in v1.5.1 for EXIF orientation flags

In v1.5.1, the Image Orientation is wrong in both, thumbnail and full-screen mode,
for the following Picture Rotation Exif flags:

  • "Right-Hand, Top"
  • "Bottom, Right-Hand"
  • "Left-Hand, Bottom"

It works correct for:

  • "Top, Left-Hand"

I'm not sure if the Menu entry "automatic rotation" works, as it does not change any behavior.

Suggest Changing Interpolation Type

I have noticed poor image quality, such as jagged edges and blurry text, for slides where the resolution of the images is significantly higher than that of my display. This is for an image that is resampled (down-sampled), i.e. when the option "Show Large Images at Actual Size" is not selected.

My suggestion is to change NSImageInterpolationLow to NSImageInterpolationHigh:

[cg setImageInterpolation:zoom > 1 ? NSImageInterpolationNone : NSImageInterpolationLow];

On modern hardware, using better image resampling should have minimal performance impact. I have recompiled the software on my computer and verified that this significantly improves image quality with no impact on the time it takes to flip slides (macOS 10.12 Hackintosh, Intel i5-6500, 16 GB RAM),

Thank you for considering this issues!
Best,
Sam

No EXIF data shown for HEIC files

No EXIF data is shown for HEIC fotos after pressing 'I' and 'SHIFT-I'.
(But it works nice for jpg files.)

  • Phoenix Slides 1.4.7 and 1.4.8 (I just realized it now, as I handle HEIC fotos first time),
  • OS: MacOS 13.x and 14.x,
  • my HEIC fotos are saved from iMessage (I do not have other HEIC fotos to test at the moment),
  • when I open these HEIC fotos in Photoshop and save them as jpg, all original EXIF data is shown then in Phoenix Slides,

Request: Set the default way to open pictures as window mode

Whenever I open a picture to browse, it always maximizes to fill the entire screen. I would rather browse in window mode. Please provide this option! Thank you so much

In addition, please provide cmd key plus mouse wheel zoom image shortcuts, very much needed, thank you

Access to /Volumes is lost if another user is logged in.

If there are multiple users and more than one are logged in, then Phoenix Slides stops working entirely as it loses access to any and every directory.

Logging out all other uses and then restarting Phoenix Slides fixes the issue. However, this also causes rescanning the image directory from scratch thereby defeating the purpose of fast user switching on a mac.

I tried providing full disk access (not desirable) to Phoenix Slides in System Preferences but even then it does not help and Phoenix Slides is unusable if multiple uses are logged in.

Thumbnail View does not refresh photos with new "Modify Date/Time" anymore on v1.4.8

In "Thumbnail View", a click on the folder does not update anymore the Thumbnails of changed photos, even they have a newer "Modify Date/Time". It only acts on added or deleted files when refreshing the Thumbnail View.

Scenario: After editing a photo in e.g. Photoshop, the file gets a new "Modify Date/Time", but the "Thumbnail View" will still show the old photo. I did not find a way to force the reload of a folder to detect the changed files, so I have to stop and restart Phoenix Slides to get the current photos shown in the "Thumbnail View".

  • It worked in Phoenix Slides 1.4.7 , but stopped working in version 1.4.8
  • MacOS 13 and 14

Request: Sort by file type

image

Add sort by file type or file extension will be nice.

Since Phoenix Slides not just show picture also pdf, I think should provide a way to just show file of picture type.

size of thumbnails too small for some JPG (since v1.5.4)

In thumbnails view, the thumbnails size of some JPG are not scaling up to the usual size anymore. Since v1.5.4. , some JPGs thumbnails are shown significantly smaller than for other JPGs. The more I crop this odd kind of photo, the smaller the thumbnail gets shown. See attached Screenshots.
This issue was introduced in v1.5.4, the v1.5.3 works fine.

The photo JPGs I tested in the screenshot below are from a Scanner with 5.000x3.000 Pixel.
But most other photo JPGs work well (e.g. from iPhone) and show the same full thumbnail size in 1.5.3 and 1.5.4.

When the user selects a very dark or very light thumbnail background color the text of the thumbnails can get unreadable

Problem

Text color of the thumbnail view changes depending on the macOS theme setting (light or dark).
This will make the thumbnail texts unreadable especially in scenarios where the theme of macOS changes automatically. It can be a problem with very light and very dark thumbnail background colors.

Dark thumbnail background color, dark color theme in macOS
image

Dark thumbnail background color, light color theme in macOS
image

Possible Solution

Rather than choosing text color (black or white) in thumbnail view based on the macOS theme it should be calculated and set by Phoenix Slides itself.

I've asked ChatGPT for a solution and it came up with choosing a white or black text color based on a luminance threshold of the background color

For ensuring text readability on various background colors, a common approach is to calculate the luminance of the background color and then decide on the text color (black or white) that provides the maximum contrast. A widely used formula for calculating the luminance of a color is based on the relative luminance in the sRGB color space, which takes into account the human eye's sensitivity to different colors.

The relative luminance $((L))$ of a color is calculated using its RGB components $((R, G, B))$ as follows:

  1. Convert the RGB values to the range 0–1 by dividing them by 255 (if they're in the 0–255 range).
  2. For each color (R, G, B), apply the following transformation:
    • If the color's value $((C))$ is less than or equal to 0.03928, then $(C = C / 12.92)$.
    • Otherwise, $(C = ((C + 0.055) / 1.055) ^ 2.4)$.
  3. Calculate the luminance $((L))$ using the formula:
    $[L = 0.2126 \times R' + 0.7152 \times G' + 0.0722 \times B']$

where $(R')$, $(G')$, and $(B')$ are the transformed R, G, and B values, respectively.

If the luminance is below a certain threshold (e.g., 0.5), use white text; otherwise, use black text.

Here's how you could implement this in Objective-C for a desktop Mac application:

#import <Cocoa/Cocoa.h>

@interface ColorUtility : NSObject

+ (NSColor *)textColorForBackgroundColor:(NSColor *)backgroundColor;

@end

@implementation ColorUtility

+ (NSColor *)textColorForBackgroundColor:(NSColor *)backgroundColor {
    CGFloat red, green, blue, alpha;
    
    // Convert the background color to the RGB color space
    NSColor *rgbColor = [backgroundColor colorUsingColorSpace:[NSColorSpace sRGBColorSpace]];
    [rgbColor getRed:&red green:&green blue:&blue alpha:&alpha];
    
    // Calculate the luminance of the background color
    CGFloat luminance = [self luminanceForRed:red green:green blue:blue];
    
    // If the luminance is greater than 0.5, black text is more readable; otherwise, use white text
    if (luminance > 0.5) {
        return [NSColor blackColor];
    } else {
        return [NSColor whiteColor];
    }
}

+ (CGFloat)luminanceForRed:(CGFloat)red green:(CGFloat)green blue:(CGFloat)blue {
    CGFloat components[3] = {red, green, blue};
    for (NSInteger i = 0; i < 3; i++) {
        components[i] = (components[i] <= 0.03928) ? (components[i] / 12.92) : pow((components[i] + 0.055) / 1.055, 2.4);
    }
    return components[0] * 0.2126 + components[1] * 0.7152 + components[2] * 0.0722;
}

@end

In this code, ColorUtility is a utility class with a method textColorForBackgroundColor: that calculates the appropriate text color (black or white) for a given background color. The method luminanceForRed:green:blue: computes the luminance of the color, which is then used to determine the text color that ensures good readability. This approach works well for most scenarios and adheres to accessibility standards for contrast and readability.

bug report: since 1.5.7 problem with sony arw files

Hi!
With version 1.5.6 it is possible to see thumbnails and open dia-show with sony *.arw files.
In version 1.5.7 thumbnail views are displayed but starting dia-show will end in an icon that shows a broken file with width 0px and height 0px.
What can I do to get the slideshow running again?
Thanks!

Request: Custom keymapping feature

It would be great to be able to remap the keys. Like traverse through the images with Z and X while using arrow up/down to zoom in/out.

I see there was something similar proposed in the issue below. However it would be nice to have this functionality as a .conf file for phoenix slides.
#44

Picture display quality is not as good as on Preview or Xee on JPEG

I'm currently evaluating a replacement for Xee3 (very unhappy they stopped development long time ago).

It seems Phoenix Slides checks the most important check boxes for me (like e.g. color accuracy and nice native zoom behaviour).

However I'm really picky with my image viewer of choice and have done a 1:1 comparison of Phoenix Slides, Preview and Xee with mostly JPEGs.

The problem

I noticed that Phoenix Slides pictures are a more blurry / less sharp than from Preview and Xee. I've created a 200% Nearest neighbour Zoom for comparison reasons. Note: The quality difference is also visible on smaller than screen images (so the issue is not the downsampling). I'm guessing a faster decompression algorithm of JPEGs is used to make Phoenix snappier.

Is it possible to get a high quality decrompression of JPEGs (even optional in settings would be good) with Phoenix to make it equal to display quality of Preview?

The original image from this issue is available for free here: https://negativespace.co/woman-model-street/

Look especially at the eyes, eyelashes, eyebrows, skin pores in the comparison

Phoenix Sildes (more blurry)

phoenix

Preview (sharper)

preview

1:1 comparison on the eye region

1to1_comparison

WebP Support

Feature request: Hoping to get support for WebP files.
Thanks for all your work.

Alert after deleting picture

In full screen mode, after deleting a picture (with cmd-delete) an alert appears with the following text:

"The file XXXX could not be moved to the trash because an error of -1 occurred."

Request: Show basic data optionally in Full Screen mode

When showing an image in full screen mode, it would be handy to press a button & instantly see the name of the image(+folder it's in) and which number it is out of all the images in the selection (i.e. 3/10 for image 3 out of 10).

Program crashes entirely when folder includes a DNG file

How to reproduce the bug

Version 1.5.5

Have a mixed folder with some JPEGs and one or more DNG in the folder.

DNG is a RAW file generated e.g. by Adobe Photoshop RAW or Adobe Lightroom.

Open a JPEG file.

Note: Here is a sample DNG from me to reproduce the error. You can download the DNG from the top right there.

What happens

Phoenix Slides crashes entirely during analysing the folder. I only tried to open a JPEG and did not try to open the DNG directly. When I remove all DNG from the folder it does not crash anymore.

What is expected

I don't expect Phoenix Slides to open RAW files like DNG really (I have other programs for that like Lightroom etc) but at the same time I don't expect it to crash entirely. A placeholder info image which says e.g. that the DNG could not be opened would be nice.

It would be great if it "only" crashes internally and gracefully on trying to access the DNG file but not taking the whole program with it.

Feature Request: Add option to disable re-scanning directory when volumes are mounted/unmounted

It seems that when volumes are unmounted/mounted (in my case by Time Machine), it causes Phoenix Slides to re-scan the directory that’s open (even if that directory is un-affected by the unmount/remount). This causes the app to lose it’s place in the scroll of photos, which can be really annoying when going thru a lot of photos.

Would it be possible to add a checkbox to disable this rescan behavior?

Thanks!

Enhancement Request: Use "Slideshow Window" for image info

Thanks for adding view in Window in #12 (and for considering the #42 enhancement).

Another enhancement that would be helpful is to use the window title bar (currently always "Slideshow Window") to display either the current file name, or all the information of the File info from the bottom info bar.

Here's how another system displays images in window view:
Screenshot 2024-02-28 at 11 10 01

Thank you!

bug/feature request - slideshow stops advancing after using left arrow

A slideshow stops advancing automatically when it is interrupted by using the left arrow key to go back one or more images. It will advance one image at a time using the right arrow key, but does not resume continuous playback. This behavior occurs whether or not the slideshow has been paused using the spacebar. It also occurs whether or not the slideshow is set to random or sequential playback. It would be great if the slideshow were to resume where it left off after it the back arrow shortcut was used.

Phoenix Slides version 1.5.7 (30)
Macos 12.7.3

Bug - Can't open images in subfolders with ä ö ü in folder name since macOS 11

First of all thank you very much for the best image viewer on Mac!

Since the upgrade from macOS 10 to 11 and to a newer version of Phoenix Slides, the app doesn't open images in subfolders with ä ö ü in the folder name if the directory reaches a certain length.
e.g. /Users/mac/files/further ideas/businesscards/products türen/01.jpg

Phoenix Slides is able to open images if there are less subfolders.
e.g. /Users/mac/files/fotos/motorräder/cafe racer/01.jpg

Would be great if the app would support directories with more than 300 characters.

Thanks!

Audio-advance settings don't save

I generally turn auto-advance off. However, whenever I relaunch the app, auto-advance is turned back on. The number of seconds does save. The workaround I've found is to set auto-advance to 0 seconds, but the checkbox remains checked once I've relaunched the app.

Support for extra file formats through quicklook

Many apps use a call to quicklook to support some more esoteric file formats. Right now I'm thinking of Affinity photo and designer file formats, but there are several others, particularly in the sciences and vector design areas.

Enhancement request: slideshow in resizeable window mode

Thank you for this great and nifty software. I discovered this gem while looking for a substitute for xee2.2

Suggest a few improvements with reference to this closed issue:
#12

  1. The window should resize "automatically" to the image displayed.
    Currently the window is larger than the images opened with black filler. When we scroll through the images, the window should keep automatically resizing so as to fit the image. In this new behavior, images should fill the window.

  2. An option to start Phoenix slides in the above mode.
    Right now, when i double click an image it will start the slide in full-screen. No option to start a slideshow in window mode. This new option (checkbox) may be added in Preferences:Slideshow > when opening files from the finder >start slideshow > "Open in window mode"

  3. When opening any file from the finder, NOT to show the separate browser window.

Thank you again.

Request: Display the jpeg (EXIF) comment at the bottom of the slide image

I have been using Phoenix Slides for many years to view images scanned in from slides. I use the jpeg (EXIF) comment to label the images and although it is available to view in the upper right corner of the display it would be more convenient to have it displayed at the bottom of the image in a larger font.
Thank you.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.