Giter Club home page Giter Club logo

transmitter's Issues

Unsubscribing from a subscriber causes other subscribers to be dropped

If a subscriber function disposes itself and is not the last subscriber in the array, a subscriber will be skipped. This occurs because the unsubscribe method removes an element from the array on which forEach is called. The following test case demonstrates the issue:

  'unsubscribe while pushing'() {
    const bus = transmitter()
    const subscription = bus.subscribe(function () { subscription.dispose() })
    const spy = sinon.spy()
    bus.subscribe(spy)

    bus.push(1);

    assert(spy.calledOnce, 'spy should be called once.')
    assert.equal(spy.callCount, 1, 'spy should be called exactly once.')
  }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.