goats2k / overpass Goto Github PK

If the user changes their avatar on Discord, displaying their old avatar will return a 404.

Having a window that can show the ingress contents could be nice - direct feedback that the stream is live.

I wanted to more leave this as a discussion, but I think some unit tests would make your code base much easier to ensure that a change doesn't break everything.

Discord usernames can contain pretty much any unicode character, which is a problem for Overpass when it comes to displaying streams.

Problem

Currently, stream URLs look something like this /watch/<username>
This can potentially become a problem if the username looks something like "Example / User", the problems it introduces are:

• Unless the slashes are escaped by the browser, the stream will simply not work.
• The URL becomes harder for the user to type, if they just want to watch a user when they're live.

Potential solutions

• Force every user to create a "display name" and make sure the name only contains letters, numbers and simple symbols.
• Generate a display name based on their username on the server side.

Filter out anything that doesn't match [A-Za-z0-9].

• Use an ORM
• Refactor database table (user_id instead of user_snowflake in `streams`` for example)
• Set up some sort of migrations system

We should only save filenames to be able to allow for more portability in case the user wants to move the archive elsewhere.

Once the archive gets a bit fuller, we'll need some sort of pagination mechanism.

Could be cool to have an announcement feature of sorts for Discord for example.

Would be cool to have a cache of sorts, to allow rewinding of the stream.

Routes are configured differently in FastAPI, so they need to be changed.

A chat widget that's mapped to a Discord channel could be cool!

At some point, I will swap out the jinja templates with a SPA - but for that we need to turn Overpass into a REST API.

https://fastapi.tiangolo.com/

It could be an idea to scrap the archive and rather focus on individual users' past streams.

Getting this after Discord Auth:

This is in the terminal:

^Cilfs@ilfsZ:~/overpass$ flask run
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://127.0.0.1:5000/ (Press CTRL+C to quit)
127.0.0.1 - - [18/Dec/2021 13:34:25] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [18/Dec/2021 13:34:27] "GET /auth/login/ HTTP/1.1" 302 -
127.0.0.1 - - [18/Dec/2021 13:34:30] "GET /auth/callback?code=fnL7Nt63FT7glFebNGksKvDdk7eMhh&state=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJfX3N0YXRlX3NlY3JldF8iOiIycTA1OURKejNhQjFzUkp0Z2pGNm1OeFc1ZFRRb3oifQ.clrqRbaC1UR1UUaX5G6z4V3aNzKKeD0Yzl589Y2OPeg HTTP/1.1" 308 -
Exception on /auth/callback/ [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.8/dist-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/ilfs/overpass/overpass/routes/auth.py", line 47, in callback
    discord.callback()
  File "/usr/local/lib/python3.8/dist-packages/flask_discord/client.py", line 157, in callback
    token = self._fetch_token(state)
  File "/usr/local/lib/python3.8/dist-packages/flask_discord/_http.py", line 93, in _fetch_token
    return discord.fetch_token(
  File "/usr/local/lib/python3.8/dist-packages/requests_oauthlib/oauth2_session.py", line 239, in fetch_token
    self._client.parse_request_uri_response(
  File "/usr/lib/python3/dist-packages/oauthlib/oauth2/rfc6749/clients/web_application.py", line 203, in parse_request_uri_response
    response = parse_authorization_code_response(uri, state=state)
  File "/usr/lib/python3/dist-packages/oauthlib/oauth2/rfc6749/parameters.py", line 268, in parse_authorization_code_response
    raise MismatchingStateError()
oauthlib.oauth2.rfc6749.errors.MismatchingStateError: (mismatching_state) CSRF Warning! State not equal in request and response.
127.0.0.1 - - [18/Dec/2021 13:34:30] "GET /auth/callback/?code=fnL7Nt63FT7glFebNGksKvDdk7eMhh&state=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJfX3N0YXRlX3NlY3JldF8iOiIycTA1OURKejNhQjFzUkp0Z2pGNm1OeFc1ZFRRb3oifQ.clrqRbaC1UR1UUaX5G6z4V3aNzKKeD0Yzl589Y2OPeg HTTP/1.1" 500 -

Here is the .env file

Any idea how to resolve this.

This should not be possible.

A user can only have one livestream going at a time.

Use this instead.

https://github.com/Tert0/fastapi-discord

An admin panel should have the following features:

• Manage users (list / update / ban)
• Manage streams from all users (add or remove from the archive)
• Get user role from discord server if environment variable is set

Rewrite db.py.

This should've probably been done a long time ago...

The current playlist re-writing function is quite inefficient as it runs on every GET /hls/<unique_id>/index.m3u8, instead of updating whenever the last chunk is out of date. This doesn't scale well with many concurrent viewers.

Been requested by multiple code reviewers...

v1 should have a concept of roles (view-only, streamer, admin) etc

Could be interesting to try to implement a viewer count!

FastAPI will be using Uvicorn instead of Gunicorn.

Hi, I was curious if it'd be possible to get a docker image built for linux/amd64?

I've been interested in running this project for a few days and finally got around to attempting to get it running only to find out Docker images intended for armv7 cannot be ran on amd64 platforms.

I'm not experienced with Docker by any means so maybe im missing something super obvious so im kind of stuck unless I attempt to build manually.

Thanks and I hope to see this project grow.

The way Overpass updates a stream's playlist file right now, will not scale well in the future.

Upon receiving a GET request for a playlist file, we re-write the playlist file to make sure we're on track with the playlist file generated by nginx.

https://github.com/GOATS2K/overpass/blob/master/overpass/hls.py#L32

However, this also means that this function runs on every single request, which is way more frequently than it would ever have to.