Unable to set custom `http.RoundTripper` about resty HOT 10 CLOSED

@jeevatkm

Existing timeout, TLS and proxy resty interfaces are looking simple and solid so we definitely should keep them around without making anything there harder to use.

On the other hand, giving users ability to override RoundTripper will provide the library with extra flexibility which is good thing to have as well.

The way to get this done I see at the moment is to provide users with SetRoundTripper method on Client along with documentation describing that tls/timeout/proxy methods will not work unless that RoundTripper provided is not an http.Transport. So it is more like "if you know what you are doing - have fun" kind of method.

And the proxy/timeout/tls methods stay with the same interface, they will just do type assertion on roundTripper they have available and do nothing if it is not and http.Transport (+ log the error like in https://github.com/go-resty/resty/blob/master/client.go#L535 to get user and idea that something is likely wrong).

Does this sound sane?

from resty.

@bak1an I need a time to analyze and get back to you. However your description makes sense.

from resty.

@bak1an I took longer than I expected to respond for your query.

I would like to give you a background. Since v0.11 release -

• After calling SetTransport method and then user calls any methods, those supplied values (Proxy, TLS, etc.) gets into the object they have supplied and resty is using that internaly.
• Timeout is applied in the http.Client.Timeout

Now let's get back to your question, whether adding support for http.RoundTripper and keeping existing features intact would benefit resty users? If answer is yes then please count me in.

Looking forward to your thoughts.

from resty.

Let me take another look at this...

from resty.

Sure, I will wait for your inputs.

from resty.

Whenever you have inputs please let me know. Thanks.

from resty.

@bak1an

Yes it's sounds good. Thank you.

from resty.

@jeevatkm Then I will make a PR for this around the end of the week. Thanks!

from resty.

@bak1an working on PR #74 for this feature.

from resty.

Implementation is in #91, closing it.

from resty.