Comments (6)
jeevatkm
commented on May 28, 2024
@renom Could you explain your request in detail along with some samples, please?
I need more confidence about using the same instance of Context in all the requests.
from resty.
jeevatkm
commented on May 28, 2024
@renom Any feedback?
from resty.
renom
commented on May 28, 2024
@jeevatkm thanks for the response.
I thought about initializing the client once when multiple requests are sent further in the same code block.
Or setting the context when the client is passed to another service as a func argument, to avoid passing the context separately.
If you still need code examples, I can make them a little bit later.
from resty.
renom
commented on May 28, 2024
Case 1 (now):
func DoSomething(ctx context.Context, url1, url2, url3 string) (err error) {
client := resty.New()
_, err = client.R().SetContext(ctx).Get(url1)
if err != nil {
return err
}
_, err = client.R().SetContext(ctx).Get(url2)
if err != nil {
return err
}
_, err = client.R().SetContext(ctx).Get(url3)
if err != nil {
return err
}
return nil
}Case 1 (updated):
func DoSomething(ctx context.Context, url1, url2, url3 string) (err error) {
client := resty.New().SetContext(ctx)
_, err = client.R().Get(url1)
if err != nil {
return err
}
_, err = client.R().Get(url2)
if err != nil {
return err
}
_, err = client.R().Get(url3)
if err != nil {
return err
}
return nil
}from resty.
renom
commented on May 28, 2024
Case 2 (now):
func DoSomething(client *resty.Client, ctx context.Context, url1, url2, url3 string) (err error) {
_, err = client.R().SetContext(ctx).Get(url1)
if err != nil {
return err
}
_, err = client.R().SetContext(ctx).Get(url2)
if err != nil {
return err
}
_, err = client.R().SetContext(ctx).Get(url3)
if err != nil {
return err
}
return nil
}Case 2 (updated):
func DoSomething(client *resty.Client, url1, url2, url3 string) (err error) {
_, err = client.R().Get(url1)
if err != nil {
return err
}
_, err = client.R().Get(url2)
if err != nil {
return err
}
_, err = client.R().Get(url3)
if err != nil {
return err
}
return nil
}We can still pass the context:
err := DoSomething(client.SetContext(ctx), url1, url2, url3)from resty.
jeevatkm
commented on May 28, 2024
@renom Thank you for the code snippets to explain the use case flow.
from resty.
Related Issues (20)
- Call to http.DetectContentType has trailing NUL bytes in buffer HOT 1
- The SetContentLength(boo) method may cause an out-of-memory issue when uploading large files, such as 5GB. HOT 1
- CVE-2023-45286 HOT 3
- Breaks application from Ctrl-C handling HOT 1
- Brotli support HOT 1
- How to handle response if a call to API returns 200 with struct A, or 201 with struct B? HOT 3
- SetResult failed with httpmock HOT 2
- CVE-2023-45286: HTTP request body disclosure HOT 3
- SetProxy HOT 3
- The request with SetFileReader retry time great than 1 will has issues HOT 1
- Signing requests with path parameters HOT 1
- Clone or copy of existing client HOT 6
- cache middleware HOT 5
- retrying of non-idempotent methods HOT 2
- Path param encoding is broken
- can't use image.decode on rawbody HOT 1
- Can it support socket5 proxy? HOT 2
- Resty retry function does not work in Slack as custom http client HOT 2
- Middleware around resty.Request.Execute including retries HOT 1
- about proxy
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from resty.