Comments (2)
Hey there, @techidea8! Good to see you back with more insights. 👋
Thank you for your feature request. I understand that you would like to extend the AgentServiceRegistration
struct to support additional attributes, specifically the tags
array, for better compatibility with Traefik gateway and Consul registry.
Currently, the Kratos framework does support the tags
attribute, but it's limited to a single tag constructed from the service version. This is evident in the contrib/registry/consul/client.go
file:
asr := &api.AgentServiceRegistration{
ID: svc.ID,
Name: svc.Name,
Meta: svc.Metadata,
Tags: []string{fmt.Sprintf("version=%s", svc.Version)},
TaggedAddresses: addresses,
}
To support additional tags, you can modify the Tags
field assignment in the AgentServiceRegistration
struct to include more entries. For example, if you want to add custom tags or include more service-specific information, you can extend the Tags
slice with additional strings. Here's a hypothetical example of how you might modify the code to include extra tags:
// Assuming svc.Tags is a []string field that contains additional tags you want to register.
asr := &api.AgentServiceRegistration{
ID: svc.ID,
Name: svc.Name,
Meta: svc.Metadata,
Tags: append([]string{fmt.Sprintf("version=%s", svc.Version)}, svc.Tags...),
TaggedAddresses: addresses,
}
In this example, svc.Tags
is assumed to be a slice of strings that contains additional tags you wish to register with Consul. This approach allows you to dynamically add as many tags as needed to the service registration, improving compatibility and integration capabilities with tools like Traefik that can utilize these tags for routing, service discovery, and configuration purposes.
Remember, for this approach to work, you would need to ensure that the registry.ServiceInstance
struct (or whichever struct svc
is an instance of) includes a Tags
field or some mechanism to specify additional tags. This might require modifications to the service instance struct and any related logic for populating or passing these tags through the system.
I hope this helps! If you have any further questions or need more clarification, please don't hesitate to ask.
Sources
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.
from kratos.
I understand what your mean
in fact i support this feature using "github.com/hashicorp/consul/api"
The best way is the team of go-kratos modify kratos to support this feature
we work use devops platform like codeup
it‘s not a good idea for me to modify kratos framework
it will affect our other application
from kratos.
Related Issues (20)
- When the App stops, the ctx in the afterStop callback is not available HOT 3
- [Question] How to return other Status Code in a successful HTTP request? HOT 7
- [Feature] Add Unwrap to custom response writer. HOT 3
- [Proposal] config feature roadmap HOT 22
- [Feature] replace kratos metrics with otel metrics HOT 3
- [The modification of header file information of http response does not take effect] ctx.Header().Set("Content-Type", "application/octet-stream") HOT 5
- [Question] How to return a custom response json? HOT 1
- Package version dependency issue HOT 4
- go generate ./...failed HOT 5
- [Feature]Add svrType related fields in proto to protoc-gen-go-http and http transport HOT 3
- proto file used to build the api document reported an error HOT 1
- consul watch, the server is offline and will not receive any notification HOT 6
- [Feature] Add NewClient method to gRPC Client HOT 3
- [Question] DDD的最佳实践方式?包括CQRS、Clean Architecture、六边形结构 HOT 5
- [Question]请教下kratos如何定义支持上传文件接口? HOT 2
- metrics statistics and usage issues [Question] HOT 5
- `stream` response in proto failed to generate http client HOT 4
- [Feature] Add kratos errors to buf remote plugin HOT 1
- [Question] I modified it based on examples/helloworld and found that client/main.go reported an error when executing. I am not sure if it is a BUG. HOT 1
- HTTPClient proto: syntax error (line 1:1): unexpected token 404 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kratos.