Giter Club home page Giter Club logo

Comments (3)

dosubot avatar dosubot commented on June 12, 2024 2

Based on the context provided, it seems like you're looking to replace the current kratos metrics with otel metrics in the Kratos framework. This is a significant change and would involve a few steps. Here's a general guide on how you might proceed:

  1. Understand the current kratos metrics implementation: As per the context, the kratos metrics functionality is designed to integrate Prometheus metrics collection and reporting into applications built with the Kratos framework. It's important to understand how this is currently implemented in the codebase. You can start by looking at the contrib/metrics/prometheus directory in the Kratos repository.

  2. Understand the otel metrics implementation: Before you can replace the current metrics with otel metrics, you'll need to understand how otel metrics works. Unfortunately, I couldn't find specific information about this in the context provided. You might want to look at the official OpenTelemetry Metrics documentation or any other resources that explain how to use otel metrics.

  3. Delete the current metrics interface: Once you understand both the current and new metrics implementations, you can start making changes to the codebase. This would involve deleting the current metrics interface. The exact steps for this would depend on where and how the metrics interface is used in the Kratos codebase.

  4. Implement middleware/metrics using otel metrics: After deleting the current metrics interface, the next step would be to implement the middleware/metrics using otel metrics. This would involve writing new code that uses the otel metrics to provide the same functionality that the current metrics interface provides.

  5. Refer to PR #2831: You mentioned that there was a previous PR (#2831) related to this. This PR could serve as a good reference for how to implement these changes. You can look at the changes made in this PR and use them as a guide for your own changes.

Please note that these are general steps and the exact process might vary depending on the specifics of the Kratos codebase and the otel metrics implementation. If you need more specific guidance, please provide more details about the otel metrics implementation and how it differs from the current kratos metrics implementation.

Sources

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

from kratos.

Ccheers avatar Ccheers commented on June 12, 2024

assign me

from kratos.

kratos-ci-bot avatar kratos-ci-bot commented on June 12, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


kill me

from kratos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.