error in getHeader() about bam-js HOT 7 CLOSED

I can reproduce this. I think I have a fix and will release a new version shortly, just need to make sure to test!

from bam-js.

@lidaof Ok I have made two changes that should fix this, mostly with regards to compatibility with the browser's native fetch. If you want to try updating to @gmod/[email protected] to give it a shot that would be great!

from bam-js.

hi @cmdcolin thanks for fast fix, i can confirm if it's bamUrl, it's fixed. if use a bamPath, a new error raised :)

from bam-js.

I think you can't use bamPath in the browser as that tries to access the filesystem directly via node.js file system calls and this does not exist in the browser.

If you want to access for example a file that a user opened in the browser, you might want to use the BlobFile class in https://github.com/GMOD/generic-filehandle and pass it to the bamFilehandle/baiFilehandle argument. The bamPath/bamUrl are just convenience methods for using the generic-filehandle class directly

from bam-js.

Note that some of your earlier comments about this topic of opening files actually motivated the creation of generic-filehandle so I hope it is useful :) feel free to provide feedback

from bam-js.

It's designed hopefully to be usable across multiple modules such as cram-js, bam-js, bbi-js, tabix-js, etc.

from bam-js.

oh...yeah..stupid me....what i was thinking using local path in browser....sorry!
Thank you!! @cmdcolin

from bam-js.