nonce global issue about esbuild-sass-plugin HOT 3 CLOSED

On Tue, Mar 29, 2022 at 12:18 AM Gianluca Romeo ***@***.***> wrote: [image: bitmoji] <https://camo.githubusercontent.com/411d2c1dfad25cdc94dc33749b3ae4bd1b06cb5419a0532b86f54efdd1073978/68747470733a2f2f73646b2e6269746d6f6a692e636f6d2f72656e6465722f70616e656c2f37653362633435332d363466622d346133342d626361612d3438313732346535643364392d37373462663138342d626331632d346634382d613632372d3833363137323061666131302d76312e706e673f7472616e73706172656e743d312670616c657474653d312677696474683d323436> I rather not pollute the window scope for that... How about we make so that you can bundle AppB leaving nonce unresolved and then bundle AppA using define? In theory, this means you need to have two build target for your AppB one for when you want to use it standalone (if you do) and one for when it has to be re-bundled in AppA. Suppose you pass in AppB build { "nonce": "__whatever__" } then it leaves __whatever__ accessed globally and unresolved. (call it __esbuild_nonce__ if you prefer, assume the code will just look at the string starting with __). At this point you can specify window.__whatever__ = "1234..." and that would work as you intended, but you can also just bundle AppA passing define: { "__whatever__": "1234..." } and that avoids polluting the global scope. — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEA6CIVBOYRV2PJ4SLKC7P3VCHLTPANCNFSM5R2DZIZA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

it works for me thank you very much On Tue, Mar 29, 2022 at 12:18 AM Gianluca Romeo ***@***.***> wrote: > [image: bitmoji] > <https://camo.githubusercontent.com/411d2c1dfad25cdc94dc33749b3ae4bd1b06cb5419a0532b86f54efdd1073978/68747470733a2f2f73646b2e6269746d6f6a692e636f6d2f72656e6465722f70616e656c2f37653362633435332d363466622d346133342d626361612d3438313732346535643364392d37373462663138342d626331632d346634382d613632372d3833363137323061666131302d76312e706e673f7472616e73706172656e743d312670616c657474653d312677696474683d323436> > > I rather not pollute the window scope for that... > > How about we make so that you can bundle AppB leaving nonce unresolved > and then bundle AppA using define? > > In theory, this means you need to have two build target for your AppB one > for when you want to use it standalone (if you do) and one for when it has > to be re-bundled in AppA. > > Suppose you pass in AppB build > > { > "nonce": "__whatever__" > } > > then it leaves __whatever__ accessed globally and unresolved. (call it > __esbuild_nonce__ if you prefer, assume the code will just look at the > string starting with __). > > At this point you can specify window.__whatever__ = "1234..." and that > would work as you intended, but you can also > just bundle AppA passing define: { "__whatever__": "1234..." } and that > avoids polluting the global scope. > > — > Reply to this email directly, view it on GitHub > <#76 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEA6CIVBOYRV2PJ4SLKC7P3VCHLTPANCNFSM5R2DZIZA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >