If esbuild is in watch mode and there is an error in sass, the plugin stops working about esbuild-sass-plugin HOT 8 CLOSED

@ArthurHeitmann thanks for spotting it! I need to improve my publish pipeline 🤦‍♂️

from esbuild-sass-plugin.

Ok, fixed that in v1.4.11

from esbuild-sass-plugin.

I could fix this issue by handling more gracefully the errors but at best I would have to cache the watchedFiles from the last successful build which I'd rather not do because esbuild does it already.
It wouldn't make the plugin slower but it would make it more memory hungry and I don't like that.
Let's keep this issue open until we see where esbuild goes with the issue #1063, I will then provide a fix accordingly.

from esbuild-sass-plugin.

I see the problem. In the meanwhile I have a fix on my fork. I don't really know much about sass compilation or esbuild plugins, so I don't know if I missed something.

Unused memory is wasted memory

         -- someone on reddit

from esbuild-sass-plugin.

Given the cache is used only in watch mode I ended up providing a fix in v1.4.10

from esbuild-sass-plugin.

Seems we were thinking the same thing. Thank you

from esbuild-sass-plugin.

Sorry I wasn't paying attention... your PR would have been welcome.

from esbuild-sass-plugin.

Did you forget to run tsc before publishing? Because in the plugin.ts it says build.initialOptions and in plugin.js it just says build. And btw. the watch parameter can also be false :)

from esbuild-sass-plugin.