Giter Club home page Giter Club logo

Comments (3)

glromeo avatar glromeo commented on May 30, 2024

Hi @jakajancar thank you for the heads-up... I can see here sass/sass#3065 that this was an issue with dart-sass. I have released v1.4.7 in which I have upgraded sass to 1.35.1. This should fix the issue

from esbuild-sass-plugin.

jakajancar avatar jakajancar commented on May 30, 2024

I'm still seeing the warnings:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($l1 + 0.05, $l2 + 0.05)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
126 │   @return if($l1 > $l2, ($l1 + .05) / ($l2 + .05), ($l2 + .05) / ($l1 + .05));
    │                         ^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules/bootstrap/scss/_functions.scss 126:25  contrast-ratio()
    node_modules/bootstrap/scss/_functions.scss 108:22  color-contrast()
    src/theme/_badge.scss 32:12                         @import
    src/theme/_theme.scss 18:9                          @import
    src/main.scss 11:9                                  root stylesheet

:/

from esbuild-sass-plugin.

glromeo avatar glromeo commented on May 30, 2024

That might be because as per sass docs

Stylesheets that are imported relative to the entrypoint are not considered dependencies.

I was able to silence the warnings and now my tests don't show any even with bootstrap

Have a look at this example

esbuild-sass-plugin/test/fixture/bootstrap/entrypoint.scss

Line 3 in a2cf9c9

@import "~bootstrap/scss/bootstrap.scss";

Your case might be slightly different but in a nutshell make sure that the import isn't perceived from sass as relative.

from esbuild-sass-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.