Giter Club home page Giter Club logo

todolist's Introduction






๐Ÿ“ˆ Contribution Graph
Contribution Graph



todolist's People

Contributors

gloireirenge avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

todolist's Issues

Javascript best practice exercice

  • all Javascript files are kept in a new. JS file not in the script tags
  • console.log is not used on the project
  • .lock files is not in the repository. it should be there to avoid problems with future versions of the dependencies as I'm using node_modules.
  • document.write or eval is not used
  • window.alert() or window.confirm() is not used

P2p code review 8/16/22

Feedback from Aamir Khan

Hi @GloireIrenge, your project is looking beautiful so far. However, there are issues that you need to go through.

  • The deployment is not looking correct it is beacuse CSS and JS are not loading well, please kindly fix it.
  • Please create different modules not write all codes in one module.
  • As much as you can it is better to follow the javascript best practice , for example, it is better to use a local variable instead of the global variable.

Feedback from Meshu Amare

  • From src/index.js on line number 60,110 you declare a variable. I think it is better to put it at the top of the script.
  • When you declare a variable if the variable has two words like DeleteSelected it is better to use camel case notiation like deleteSelected

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.