Formatting Issues about globalphone HOT 9 CLOSED

Oki, I've added a failing test for this issue:
https://github.com/wallymathieu/GlobalPhone/commit/e5f89c714abb286e765529b9b9d528862cbd48b1

from globalphone.

Should be better after:
https://github.com/wallymathieu/GlobalPhone/commit/b5b6505206520bc1db05dc22e8de5b6645f3dbfe

from globalphone.

I see you have changed the format in b5b6505:

-              Assert.That(number.NationalFormat, Is.EqualTo("07411 111111"));
 +            Assert.That(number.NationalFormat, Is.EqualTo("074 1111 1111"));

The first line is the correct format as seen http://goo.gl/qAVjHp

I am not sure but this may be covered in PhoneNumberAlternateFormats.xml

from globalphone.

It might be that the 07411 111111 is more correct. If you fork the lib and fix the issue you're more than welcome ;)

from globalphone.

Hi,

Thanks for the feedback. I will try to take a look when I have some time. Thanks for the bugfix (for the extra space) though.

Thanks,
Patrick

from globalphone.

I might look into what needs to be done later on. I've not much time though...

from globalphone.

One idea is to setting up a web service with the java version as backend in order to use a pretty format and then use GlobalPhone only to render numbers for search.

from globalphone.

I've made a branch alternate_formats where such refactoring might be done.

from globalphone.

If someone does a pull request with a fix, otherwise it's such a small issue.

from globalphone.