Comments (5)
Do you have a sample phone number where it fails? I tried adding regression tests to recreate the issue (https://github.com/GlobalPhone/GlobalPhone/tree/american_numbers). Perhaps you could do a pull request with a failing regression test?
from globalphone.
Pretty much any US phone number fails to correctly parse the area code and simply returns null
. For example:
801-710-1234
702-389-1234
I have forked and started looking into it only to find that it appears that the parsing of area codes is dependent on a particular pattern found in the JSON file generated from Google's phone formats. My next step was going to be to test Google's code to see if it behaves similarly.
from globalphone.
Good work!
from globalphone.
Looks like the data is missing from the json file. Does libphonenumber-csharp have the same issue?
from globalphone.
I will check it out.
from globalphone.
Related Issues (20)
- New issue Parsing Phone Numbers from Argentina HOT 2
- Normalize returns string with number even when not valid HOT 12
- TryNormalize, TryParse should match how standard .net classes work
- Should alphanumeric replacement be active for every region?
- DatabaseGenerator is concatenating leadingDigits collection from XML source into one pattern string HOT 6
- Will you support CoreCLR? HOT 7
- Override GetHashCode, Equals and "==" for Number, Region and Territory
- Object reference not set to an instance of an object Exception HOT 4
- No linux support? HOT 3
- Deprecating this lib?
- Upgrade nokogiri
- Remove parts of the lib in favor of libphonenumber-csharp HOT 3
- TryNormalize changed behavior HOT 2
- International phone number is parsed wrongly with extension!! HOT 2
- Question around assembly load From NuGet HOT 2
- Indian Mobile Numbers starting with 6 not parsing HOT 1
- how to use GlobalPhoneDbgen HOT 2
- ArgumentNullException for TryParse(null) HOT 5
- Look into merging this pull request into c# HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from globalphone.