Giter Club home page Giter Club logo

Comments (5)

wallymathieu avatar wallymathieu commented on June 2, 2024

Do you have a sample phone number where it fails? I tried adding regression tests to recreate the issue (https://github.com/GlobalPhone/GlobalPhone/tree/american_numbers). Perhaps you could do a pull request with a failing regression test?

from globalphone.

matthewkimber avatar matthewkimber commented on June 2, 2024

Pretty much any US phone number fails to correctly parse the area code and simply returns null. For example:

801-710-1234
702-389-1234

I have forked and started looking into it only to find that it appears that the parsing of area codes is dependent on a particular pattern found in the JSON file generated from Google's phone formats. My next step was going to be to test Google's code to see if it behaves similarly.

from globalphone.

wallymathieu avatar wallymathieu commented on June 2, 2024

Good work!

from globalphone.

wallymathieu avatar wallymathieu commented on June 2, 2024

Looks like the data is missing from the json file. Does libphonenumber-csharp have the same issue?

from globalphone.

matthewkimber avatar matthewkimber commented on June 2, 2024

I will check it out.

from globalphone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.