glavin001 / atom-beautify Goto Github PK

See https://github.com/wistful/SublimeAutoPEP8 and https://github.com/hhatto/autopep8

Hi,

I'm using atom 0.119.0 on Windows to format my less file. Whoever the output isn't exactly better at all. Also there is a bug when using statements as &:hover and &:link

                    a {
                        line-height: @headerHeight;

display: block;
                        padding: 0px 15px;
                        font-size: 16px;
                        button {
                            font-size: 16px;
                        }
                        &:link {
                            color: @white;

text-decoration: none;
                        }
                        &:visited {
                            color: @white;

                        }
                        &:hover {
                            color: @orange;

                        }
                        &.green {
                            color: @green;

&:hover {
                                color: @white;

background-color: @green;

                            }
                        }

&:hover and &:link become &:(space)hover and &:(space)link. Which doesn't compile anymore.

support for Java would be nice,too

Hi,

Just downloaded your beautifier, it works wonderfully. I wanted to know if there is a way in the settings to have all .'s line up..

Current Code:

gulp.task('default', function() {
  return gulp.src(['./**/*.js', '!./node_modules/**'])
    .pipe(jshint())
    .pipe(jshint.reporter('default'));
});

What I would like:

gulp.task('default', function() {
  return gulp.src(['./**/*.js', '!./node_modules/**'])
                   .pipe(jshint())
                   .pipe(jshint.reporter('default'));
});

Is this currently possible?

Thanks!

Hi @Glavin001 and @karolyi,

thank you both for the great work on this project in the last weeks. Amazing! As you've seen I didn't contributed a lot recently (say: nothing).

Reasons for this: little free time and little motivation, because Atom isn't my main editor. I've created this package even before I had access to Atom, because I wanted to test the APIs for plugins :) So I couldn't know if I like Atom from a user perspective or not beforehand. It's cool, but I still need more features and stability for my daily IDE.

To make a long story short: How should this project be maintained in the future? Does one of you would like to take the leadership? Should this project be maintained by an "organization"?

Greets and sorry for letting you down,
Pipo :)

See https://github.com/sindresorhus/atom-jshint/blob/master/load-config.js#L13-L70

I am working on this now. Just confirmed it is an issue, as editor.getPath() returns the path for the current window, and of course that directory is not necessarily the project root.

Each language should have detailed installation and usage customization instructions.

See https://github.com/taronfoxworth/atom-beautifier/blob/master/lib/beautifier.coffee#L70-L94

plugin.configDefaults =
  autoSave: false
  JsIndentSize: 2
  JsIndentChar: " "
  JsIndentLevel: 0
  JsIndentWithTabs: false
  JsPreserveNewlines: true
  JsMaxPreserveNewlines: 10
  JsJslintHappy: false
  JsBraceStyle: "collapse"
  JsKeepArrayIndentation: false
  JsKeepFunctionIndentation: false
  JsSpaceBeforeConditional: true
  JsBreakChainedMethods: false
  JsEvalCode: false
  JsUnescapeStrings: false
  JsWrapLineLength: 0
  CssIndentSize: 2
  CssIndentChar: " "
  HtmlIndentInnerHtml: false
  HtmlIndentSize: 2
  HtmlIndentChar: " "
  HtmlBraceStyle: "collapse"
  HtmlIndentScripts: "normal"
  HtmlWrapLineLength: 250

I know I liked atom-beautifier a lot more because I could easily edit settings in the Atom package settings panel. And so did this user: anaptfox/atom-beautifier#3 (comment)

@karolyi , thoughts?

When beautifying a Sass document it breaks this:

a {
  line-height: 56px;
  &:hover {
     color: blue;
  }
}

It inserts a space breaking the selector: &: hover

As seen below:
http://prntscr.com/461gkr

See https://github.com/sdwood/php-beautifier and https://github.com/SublimeText/PhpBeautifier and http://pear.php.net/package/PHP_Beautifier

See autopep8 usage.

• max line length
• indent size
• ignore errors

/cc @dreid93 @liamcoau , here's to you buds :).

Hi,

Using the plugin, when the file gets modified, the cursor jumps to the end of the file.

This needs to be fixed, it had to stay at its position.

see https://www.npmjs.org/package/typescript-formatter

I'm not sure if I'm doing something wrong because using a .jsbeautifyrc is undocumented, but from your source it looks like it should be loaded.

Repro:

• Clone https://github.com/mozilla/webmaker-profile-2
• Open the cloned folder in Atom via File -> Open
• Run Beautify from Packages menu on a JS file that has some extra line breaks added

Expected:

• max_preserve_newlines is set to 1, so extra whitespace beyond 1 empty line should be removed

Actual:

• No change aside from some punctuation shifting (oddly this doesn't occur in Sublime Text, which makes me think jslint_happy is also being ignored).

Hi @Glavin001 and @karolyi,

Before leaving (?) the project (#40) I have one last question/advice:
As you've added new languages we are in the need to clarify the relation to https://github.com/beautify-web/js-beautify.

The project started as an Atom wrapper for js-beautify, but it should be treated independent to js-beautify now.
We already added a non-standard .jsbeautifyrc (#9). I would recommend to deprecate the use of .jsbeautifyrc right now and introduce a .atombeautifyrc. This JSON file collects default settings which can be used for every language, but could be overridden for a specific language (and adds language-specific settings). Something like

{
 "_default": {
    "indent_size": 4,
    "indent_char": " "
  },
  "html": {
    "brace_style": "collapse",
    "indent_scripts": "normal",
    "indent_size": 6,
    "max_preserve_newlines": 1,
    "preserve_newlines": true,
    "unformatted": ["a", "sub", "sup", "b", "i", "u"],
    "wrap_line_length": 0
  },
  "css": {
    "indent_size": 2
  },
  "js": {
    "indent_level": 0,
    "indent_with_tabs": false,
    "preserve_newlines": true,
    "max_preserve_newlines": 2,
    "jslint_happy": true
  },
  "sql": {
    "indent_level": 0,
    "indent_with_tabs": false
  },
  "python": { ... }
}

You could even exchange js-beautify for a different beautifier for JS at a later state or use different beautifier for CSS and HTML, but still use it just for JS.

Just my 2 cents :)

See https://itunes.apple.com/ca/app/gifgrabber/id668208984?mt=12 for Mac

When using the beautify command on a less file, their seems to be issues with how items are restructured. I have no custom settings or overrides.

Note: The screenshots are missing the trailing } but it is included in the raw testing text.

Before Command

After Command

LESS for Testing

@import "syntax-variables";

.editor-colors {
  background-color: @syntax-background-color;
  color: @syntax-text-color;
}

.editor {
  background-color: @syntax-background-color;
  color: @syntax-text-color;

  .wrap-guide {
    background-color: @syntax-wrap-guide-color;
  }

  .indent-guide {
    color: @syntax-indent-guide-color;
  }

  .invisible-character {
    color: @syntax-invisible-character-color;
  }

  .gutter {
    background-color: @syntax-gutter-background-color;
    color: @syntax-gutter-text-color;

    .line-number {
      &.cursor-line {
        background-color: @syntax-gutter-background-color-selected;
        color: @syntax-gutter-text-color-selected;
      }

      &.cursor-line-no-selection {
        color: @syntax-gutter-text-color-selected;
      }
    }
  }
}

Closes existing issue #45 (Java).

I am on a Mac OSX 10.9.2

With the beautify on save option checked in preferences, still nothing happens on save. Clicking beautify option or ctrl-alt-b works fine though.

• SQL, See https://github.com/vkiryukhin/pretty-data
• CSS, by js-beauty
• JSON, with comments
• XML, see #3

As mentioned here: #1 (comment)

It would be great to use a .jsbeautifyrc which looks like this (defaults):

{
    "indent_size": 4,
    "indent_char": " ",
    "indent_level": 0,
    "indent_with_tabs": false,
    "preserve_newlines": true,
    "max_preserve_newlines": 10,
    "jslint_happy": false,
    "brace_style": "collapse",
    "keep_array_indentation": false,
    "keep_function_indentation": false,
    "space_before_conditional": true,
    "break_chained_methods": false,
    "eval_code": false,
    "unescape_strings": false,
    "wrap_line_length": 0
}

And maybe .cssbeautifyrc and .htmlbeautifyrc, too. (Doesn't seem to be used by https://github.com/einars/js-beautify itself? See beautifier/js-beautify#391)

• Settings for JS: https://github.com/einars/js-beautify/blob/master/js/lib/beautify.js#L44
• Settings for HTML: https://github.com/einars/js-beautify/blob/master/js/lib/beautify-html.js#L42
• Settings for CSS: https://github.com/einars/js-beautify/blob/master/js/lib/beautify-css.js#L41

Currently you use the specific beautifiers settings (ie js is 2) when my editor is set to 4

• Keywords
  See https://github.com/ardcore/atom-colorpicker/blob/master/package.json#L7-L13 for example
  • List languages
• Contributors

Hi Folks,

bit of a strange one here but I've only noticed it since i've updated to 0.3.3 (not sure if it was going on before).

here is the contents of my .jsbeautifyrc:

{
    "indent_size": 4,
    "indent_char": " ",
    "indent_level": 0,
    "indent_with_tabs": false,
    "preserve_newlines": true,
    "max_preserve_newlines": 2,
    "jslint_happy": false,
    "brace_style": "collapse",
    "keep_array_indentation": true,
    "keep_function_indentation": true,
    "space_before_conditional": true,
    "eval_code": false,
    "unescape_strings": false
}

but it is still replacing my spaces for tabs

https://cloudup.com/cz5VzNyU_ZB

... eh.. what? things just got even stranger. I don't really know why that happened (mixed tabs and spaces).

any logs i can do to help out with this one?

You probably already know but looks like we are unable to update to 0.3.4 via the package manager. I believe this may be due to the packaging moving from @donaldpipowitch to @Glavin001 . You may need to update the repo information in package.json to point to the new URL.

Updating to “[email protected]” failed. Less…
Unable to download https://www.atom.io/api/packages/atom-beautify/versions/0.3.4/tarball: 400 Bad Request Repository inaccessible

Instead of finding the closest .jsbeautifyrc file and applying it, we should instead find all .jsbeautifyrc files upwards from the starting directory. Thus, you can apply Project Specific as a fallback for directory specific, and so forth.

See http://search.cpan.org/dist/Perl-Tidy/

Notice that in the first log, under html the indent_size is 6. However, later on it is overridden to indent_size: 6.

Issue:
saving on beautify is on yet when I save it does not beautify unless I used ctrl-alt-b first. This however prevents whitespace from ensuring a blank line at the end of the file.

Installed Packages:

/Users/.../.atom/packages (19)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

I'm also using OSX Yosemite. Not sure if that matters but this started happening in last 24 hours and I went through my install history and can't figure out what could have caused it.

Is there any info I could provide?

• Right-click single file
• Right-click directory

Hi,

beautify on save option please.

atom.workspaceView.command "core:save", => @convert()

• Track most popular languages beautified (so we know what to prioritize development on)

• Specs
  See https://atom.io/docs/latest/writing-specs
  • Fix specs that are currently hidden / disabled with underscore (_).
• Travis CI
  See https://github.com/atom/ci
  • Install dependencies for CLI beautifiers
  • Install Atom package dependencies

TODO: Current languages not working for Tests

• PHP with PHP_Beautifier is still not working. I do not yet know how to install it on Travis CI's Mac
• C++ Header test
• CoffeeScript (see #168 )

See https://github.com/derekchiang/Coffee-Formatter

See anaptfox/atom-beautifier#4

In progress 😄..

See https://github.com/taronfoxworth/atom-beautifier/blob/master/lib/beautifier.coffee#L99-L102

  atom.workspaceView.command "beautifier", -> convert()
  atom.workspaceView.command "beautifier:js", -> convertJs()
  atom.workspaceView.command "beautifier:html", -> convertHTML()
  atom.workspaceView.command "beautifier:css", -> convertCSS()

Use case: highlight a specific area of code that is a different language than the overall file's grammar type. Now apply the desired, correct, beautification.

CSS selectors like a:link becomes a: link after beautifying. This breaks those styles.

See https://github.com/badsyntax/SassBeautify

Currently there is no way to display a message to the user, such as errors or warnings or deprecation notices (see #40). Let's put a little overlay on the top for displaying such information.

See https://github.com/Glavin001/atom-logger

Trying to set the Html indent char field to \t makes it insert the characters \ and t. It's also impossible to paste a tab character into the text input.

Uncaught TypeError: Arguments to path.resolve must be strings

This occurs when beautifying on a file in a new window, because the editorFilePath is undefined.

var editedFilePath = editor.getPath();
// => undefined

This is when the file is not yet created.

• Verify that the path is being passed a valid string

Should we?

If yes, we can use: https://github.com/nodeca/js-yaml

See https://github.com/austincheney/Pretty-Diff

/cc #53 , #52

Use ActivationEvents to speed up loading time

See https://github.com/CraigWilliams/BeautifyRuby

When editing .jsbeautifyrc, and if it's in the path to be evaluated, we get an error from the config-chain module, which is right, because the invalid syntax (in the middle of editing/saving) causes the json file failing to load.

Needs to be fixed.

I'll provide a fix for this later on.

Would it be possible to add support for ReactJS JSX files?