glassechidna / artifact-cleaner Goto Github PK

I just started using this Action and had a quick look at the source code to see how it works. Based on that (and not on my experience with the Action so far) I have one suggestion: instead of terminating the Action when there is an error or an unexpected error, continue when an error occurs and report all the errors that occurred when the Action finished.

I'm not a Go expert but I would suggested doing that by returning []error in forEachArtifact and appending any errors from iter (and possibly ListWorkflowRuns?) to a slice that is returned when the last page is reached.

I do think there should be a separate way to handle the error reported in #2 to ensure the Action stops as soon as the rate limit is reached.

As an aside, based on reading the code it seems that return-on-stop is never executed because iter only ever returns true if it also returns an error. This may be simplifed by returning just an error (instead of both a boolean and an error).

Right now only the first page of runs is cleaned

Failed to run:

panic: GET https://api.github.com/repos/<repo>/actions/runs/162904418/artifacts: 500  []

goroutine 1 [running]:
main.main()
	/cleaner/main.go:62 +0x34e

No further information in the logs.

Hello,
Would it be possible to keep the last artifact of each workflow (if any). It would be handy to do proper CI/CI without overload artifact quota

When using scheduled cleanup job I get following error after deleting a few artifacts:

panic: DELETE https://api.github.com/repos/*repo_path*/actions/artifacts/2340371: 403 API rate limit of 1000 still exceeded until 2020-04-14 01:14:13 +0000 UTC, not making remote request. [rate reset in 56m45s]

Would it be possible to somehow fix this by deleting whole bunch of artifacts at once?